Skip to content

Unhandled AttributeError in parse() call #42

Description

@claudiamarcubina

Calling parse(version, loose) can return None when the provided version is not a strictly semantic version. This case is not handled when parse(version, loose) is called from valid(version, loose):

# semver.__init__.py

def parse(version, loose):
    if loose:
        r = regexp[LOOSE]
    else:
        r = regexp[FULL]
    m = r.search(version)
    if m:
        return semver(version, loose)
    else:
        return None # this can return None


def valid(version, loose):
    v = parse(version, loose)
    if v.version: # here it is just supposed that v has 'version' attribute
        return v
    else:
        return None

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions