Skip to content

python-shiny deploy fails when Connect version is unavailable #695

Description

@christierney

The following code errs when the Connect version is not included in the server settings response (Connect can be configured to hide version information.)

if not (app_mode == AppModes.PYTHON_SHINY and compare_semvers(connect_version_string, "2024.01.0") == -1):
return environment

environment = fix_starlette_requirements(
environment=environment,
app_mode=app_mode,
connect_version_string=ce.client.server_settings()["version"],

Traceback (most recent call last):

  File "/home/ USERNAME /venv311/venv_test_shiny/lib/python3.11/site-packages/rsconnect/main.py", line 118, in wrapper

    result = func(*args, **kwargs)

             ^^^^^^^^^^^^^^^^^^^^^

  File "/home/ USERNAME /venv311/venv_test_shiny/lib/python3.11/site-packages/click/decorators.py", line 34, in new_func

    return f(get_current_context(), *args, **kwargs)

           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

  File "/home/USERNAME/venv311/venv_test_shiny/lib/python3.11/site-packages/rsconnect/main.py", line 1698, in deploy_app

    environment = fix_starlette_requirements(

                  ^^^^^^^^^^^^^^^^^^^^^^^^^^^

  File "/home/ USERNAME /venv311/venv_test_shiny/lib/python3.11/site-packages/rsconnect/utils_package.py", line 220, in fix_starlette_requirements

    if not (app_mode == AppModes.PYTHON_SHINY and compare_semvers(connect_version_string, "2024.01.0") == -1):

                                                  ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

  File "/home/ USERNAME /venv311/venv_test_shiny/lib/python3.11/site-packages/rsconnect/utils_package.py", line 58, in compare_semvers

    return semver.VersionInfo.parse(version1).compare(version2)  # type: ignore

           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^

  File "/home/ USERNAME /venv311/venv_test_shiny/lib/python3.11/site-packages/semver/version.py", line 644, in parse

    raise ValueError(f"{version} is not valid SemVer string")

ValueError:  is not valid SemVer string

Internal error:  is not valid SemVer string

 

    Posit Connect version: <redacted>

Reported via https://rstudioide.zendesk.com/agent/tickets/120597

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

No labels
No labels

Type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions