Retry on failed crud uploads#16
Merged
Merged
Conversation
simolus3
marked this pull request as ready for review
July 22, 2026 09:29
rkistner
approved these changes
Jul 22, 2026
rkistner
left a comment
There was a problem hiding this comment.
I did not check all the changes in detail, but the description makes sense, and this appears to align with how we handle this in other SDKs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The state machine in upload actors to recover from upload errors was broken (the transition after
WaitingForReconnectgoes toConnectedwhich is an idle state, it should transition tostart_upload()instead).But we don't really need a separate error state in the state machine at all, we can instead use a single
asyncfunction to retry uploads in aloopuntil there are no more remaining entries or the upload is cancelled. This PR removes theWaitingForReconnectstate and migrates most of the upload logic from an explicit state machine invocation intoCrudUpload::run.AI use: Changes manual, reviewed with Claude Code.
Closes #15.