Skip to content

Fix admin authentication and routing for domain-based access#202

Merged
bokelley merged 1 commit into
mainfrom
bokelley/fix-admin-auth-routing
Oct 2, 2025
Merged

Fix admin authentication and routing for domain-based access#202
bokelley merged 1 commit into
mainfrom
bokelley/fix-admin-auth-routing

Conversation

@bokelley

@bokelley bokelley commented Oct 2, 2025

Copy link
Copy Markdown
Collaborator

Summary

Fixes authentication and routing issues where accessing admin domains was incorrectly redirecting to signup pages instead of login.

Changes

  • Nginx Configuration: Updated sales-agent.scope3.com/ to serve signup landing page instead of redirecting to admin subdomain
  • Admin UI Root Route: Added domain detection logic to properly route:
    • admin.sales-agent.scope3.com/ → Login page (super admin)
    • tenant.sales-agent.scope3.com/admin/ → Login page (tenant admin)
    • sales-agent.scope3.com/ → Handled by nginx (signup landing)
  • Signup Restriction: Added checks to block /signup access on tenant subdomains (only allowed on main domain)
  • Internal Admin Link: Maintained proper OAuth flow through /admin//login → back to admin after authentication

Expected Behavior After Fix

https://sales-agent.scope3.com/ → Signup landing page
https://admin.sales-agent.scope3.com/ → Login page for super admin access
https://wonderstruck.sales-agent.scope3.com/ → Tenant landing page (MCP/A2A info)
https://wonderstruck.sales-agent.scope3.com/admin/ → Login → tenant admin dashboard
https://wonderstruck.sales-agent.scope3.com/signup → Blocked, redirects to login
✅ "Internal Admin" links → Proper OAuth flow (/admin//login → back to admin)

Test Plan

  • Verify sales-agent.scope3.com/ shows signup page
  • Verify admin.sales-agent.scope3.com/ shows login page
  • Verify tenant landing pages still work (e.g., wonderstruck.sales-agent.scope3.com/)
  • Verify tenant admin access works (wonderstruck.sales-agent.scope3.com/admin/)
  • Verify signup is blocked on tenant subdomains

🤖 Generated with Claude Code

- Update nginx config to serve signup landing at sales-agent.scope3.com root
- Fix admin UI root route to properly handle admin vs tenant subdomains
- Restrict signup to main domain only (block access on tenant subdomains)
- Maintain proper OAuth flow: /admin/ -> /login -> back to admin after auth

This ensures:
- sales-agent.scope3.com/ shows signup landing page
- admin.sales-agent.scope3.com/ goes to login for super admin access
- tenant.sales-agent.scope3.com/ shows tenant landing (MCP/A2A info)
- tenant.sales-agent.scope3.com/admin/ requires login for tenant admin
- Internal Admin links flow through OAuth properly

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <noreply@anthropic.com>
@bokelley
bokelley merged commit e87cba3 into main Oct 2, 2025
8 checks passed
danf-newton pushed a commit to Newton-Research-Inc/salesagent that referenced this pull request Nov 24, 2025
)

- Update nginx config to serve signup landing at sales-agent.scope3.com root
- Fix admin UI root route to properly handle admin vs tenant subdomains
- Restrict signup to main domain only (block access on tenant subdomains)
- Maintain proper OAuth flow: /admin/ -> /login -> back to admin after auth

This ensures:
- sales-agent.scope3.com/ shows signup landing page
- admin.sales-agent.scope3.com/ goes to login for super admin access
- tenant.sales-agent.scope3.com/ shows tenant landing (MCP/A2A info)
- tenant.sales-agent.scope3.com/admin/ requires login for tenant admin
- Internal Admin links flow through OAuth properly

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-authored-by: Claude <noreply@anthropic.com>
bokelley referenced this pull request in bokelley/salesagent May 5, 2026
- Update nginx config to serve signup landing at sales-agent.scope3.com root
- Fix admin UI root route to properly handle admin vs tenant subdomains
- Restrict signup to main domain only (block access on tenant subdomains)
- Maintain proper OAuth flow: /admin/ -> /login -> back to admin after auth

This ensures:
- sales-agent.scope3.com/ shows signup landing page
- admin.sales-agent.scope3.com/ goes to login for super admin access
- tenant.sales-agent.scope3.com/ shows tenant landing (MCP/A2A info)
- tenant.sales-agent.scope3.com/admin/ requires login for tenant admin
- Internal Admin links flow through OAuth properly

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-authored-by: Claude <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant