Move text input style overrides into sx prop - #1446
Merged
Merged
Conversation
🦋 Changeset detectedLatest commit: ec33297 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
colebemis
commented
Sep 21, 2021
Contributor
size-limit report 📦
|
colebemis
marked this pull request as ready for review
September 21, 2021 18:39
jfuchs
approved these changes
Sep 21, 2021
jfuchs
left a comment
Contributor
There was a problem hiding this comment.
Good catch, thanks. I wonder why this typechecked without error...
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
We recently removed system props from the
TextInputcomponent (#1414) but we still relied on TextInput system props in SelectPanel. This caused a visual regression in SelectPanel:Solution
To fix this issue, I moved the TextInput style overrides into the
sxprop instead of system props.