A release push also publishes its dev build, so dev never falls behind latest - #242
Closed
wmadden-electric wants to merge 1 commit into
Closed
A release push also publishes its dev build, so dev never falls behind latest#242wmadden-electric wants to merge 1 commit into
wmadden-electric wants to merge 1 commit into
Conversation
…d latest The dev dist-tag lagged latest after every release (0.7.0 left dev at 0.6.0-dev.23; 0.8.0 left it there too), and the stale tag blocked prisma-cli's 8.0.0-rc.5 release publish on 2026-08-18. determine-version now emits a devVersion output on release pushes, and the workflow re-stamps, rebuilds, re-checks publish specifiers and publishes that build under the dev tag after the release steps. Dev pushes and dispatches are unchanged. Signed-off-by: willbot <w.a.madden+machine@gmail.com> Signed-off-by: Will Madden <madden@prisma.io>
|
Important Review available on request
Reviews should be triggered manually for repositories with fewer than 10 stars. Select Trigger review above or comment ⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro Plus Run ID: Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Contributor
Author
|
Superseded: #241 landed the same dev-tag-parity fix (devVersion output on release pushes + the dev follow-up publish steps) while this was in review. Closing; nothing here is lost. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
devdist-tag laggedlatestafter every release: 0.7.0 left it at0.6.0-dev.23, and 0.8.0 left it there again — where it blocked prisma-cli's8.0.0-rc.5release publish (dev-channel conformance refused the stale engine peer) until an unrelated commit forced a dev build out. This is the fix from prisma-cli's dev-tag-parity brief (prisma-cli#194).determine-version.tsemits adevVersionoutput, non-empty only on release pushes (computed with the testednextDevVersion; simulated release push emitsversion=0.8.0 tag=latest devVersion=0.8.0-dev.2, simulated dev push emits an emptydevVersion).publish.ymlgains four steps after the release steps, keyed on that output: re-stamp with the dev version, rebuild, re-runcheck:publish-deps, publish under--tag dev.workflow_dispatchare unchanged;actionlintpasses.Invariant delivered: every push to main leaves
devpointing at a build of that same commit.🤖 Generated with Claude Code