chore(drive): close out stage-as-branch - #49
Merged
Conversation
Slice-DoD met and proven live + in CI (isolated staging env, no-op redeploy, explicit destroy, production untouched). Durable knowledge migrated: ADR-0023/ 0024, domains docs, and the deploying-prisma-apps skill are on main; the two platform gotchas (PRO-214 branch-create idempotency, PRO-215 compute-service create collision) recorded in gotchas.md. Project dir deleted; no repo references to it remain. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Signed-off-by: willbot <w.a.madden+machine@gmail.com> Signed-off-by: Will Madden <madden@prisma.io>
wmadden
approved these changes
Jul 12, 2026
The one durable fact from the slice design log that lived only in control.ts comments: extensions are constructed in the CLI parent before the container ids exist, so constructors must tolerate their absence — only lowering hooks may require them. Surfaced by the close-out docs audit. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Signed-off-by: willbot <w.a.madden+machine@gmail.com> Signed-off-by: Will Madden <madden@prisma.io>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Close-out for the stage-as-branch slice (shipped in #42).
Slice-DoD — verified:
prisma-app deploy(default) unchanged — CI E2E green on main.deploy --stage stagingstands up an isolated environment (own Branch/compute/Postgres, preview-class config) — proven live onexamples/storefront-auth, stagingauth.verify()→{ok:true}.destroy --stage stagingremoves the Branch + resources with production untouched; destroy requires an explicit target.Durable knowledge migrated before deletion:
deploying-prisma-appsskill — already on main via feat: deploy a stage as an isolated Prisma Cloud Branch (ADR-0022/0023) #42.gotchas.md, matching its format: PRO-214 (branch create has no idempotency) and PRO-215 (project-scoped compute-service create collides with production onmain). Both filed in the compute-gotchas Linear project.Removed:
.drive/projects/stage-as-branch/(spec, plan, design-decisions). No repo references to the path remain (grep-verified).🤖 Generated with Claude Code