Close slice S2: records, retro, and what the stale-PR sweep left behind - #169
Conversation
The plan marks S2 closed in the house style (#130, #133, #132, #139), the S2d acceptance boxes are ticked against what shipped, and the closing retro lands six root-caused lessons in reviews/retro-s2-close.md — the duplicated config work, the two test-clobbers the count-diff caught, the latent init grammar collision, the ctx.host line, the coverage manifest's quoted-keys blind spot, and the Windows harness/machine disagreement. deferred.md gains two sections from today's stale-PR sweep: the live by-name production-branch bug that PR #92 fixed in code that was then deleted (it survives in commands/service/target.ts), and the four orphaned capabilities (branch remove, env pull, the github group, build-logs stream retry) with what each needs if it returns. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Signed-off-by: willbot <w.a.madden+machine@gmail.com> Signed-off-by: Will Madden <madden@prisma.io>
|
Warning Review limit reached
Next review available in: 11 minutes You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro Plus Run ID: 📒 Files selected for processing (3)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
commit: |
Process records only — no code.
S2 is done: every platform command on the engine, the Commander shell deleted, the bin cut over, the working name retired, the divergence record ratified (2026-08-12). This PR closes the books:
databasetopostgres#133,appbecomesservice: Composer makes deployments, the CLI manages them — and--yescan no longer delete anything #132, Port init, delete the Commander shell: the CLI runs entirely on the engine #139).versionremoved; the ORM's initializer atorm init).initgrammar collision, the ctx.host boundary, the coverage manifest's quoted-keys blind spot, and the Windows harness/machine disagreement.commands/service/target.tsstill has the by-name check.🤖 Generated with Claude Code