Skip to content

Rename the engine's defineConfig to definePrismaConfig - #173

Merged
wmadden merged 1 commit into
mainfrom
claude/define-prisma-config
Aug 13, 2026
Merged

Rename the engine's defineConfig to definePrismaConfig#173
wmadden merged 1 commit into
mainfrom
claude/define-prisma-config

Conversation

@wmadden-electric

Copy link
Copy Markdown
Contributor

What

Every command family ships a config helper named defineConfig — the engine's (prisma.config.ts wrapper), the ORM's (@prisma/orm-postgres/config), composer's (@prisma/composer/config). A prisma.config.ts that composes two of them has to alias imports (import { defineConfig as ormConfig } ...). This gives the engine's helper a unique name: definePrismaConfig.

  • defineConfig stays exported as a deprecated alias, so existing configs and the pinned family packages (orm-toolchain, composer, which bundle their own engine copies) keep working unchanged.
  • The CLI's own error prose (CLI.CONFIG_MISSING_MARKER, CLI.CONFIG_VERSION_UNSUPPORTED) now names definePrismaConfig.
  • Internal fixtures and tests migrated; a regression test pins the alias.

Cross-repo follow-ups (not this PR)

The same de-aliasing needs the other two helpers renamed in their own repos: defineOrmConfig in prisma/prisma's @prisma/orm-* config packages, and defineComposerConfig in @prisma/composer/config. (defineComputeConfig is already unique.)

Testing

pnpm test (1,791 green), pnpm lint, pnpm typecheck all clean.

🤖 Generated with Claude Code

Every family ships a config helper named defineConfig — the engine's,
the ORM's, composer's — so a prisma.config.ts that uses two of them
has to alias imports. Unique names remove that: the engine's is now
definePrismaConfig, and the CLI's own error prose names it. The old
name stays exported as a deprecated alias so existing configs and the
pinned family packages keep working; the ORM and composer helpers get
their unique names in their own repos.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Signed-off-by: willbot <w.a.madden+machine@gmail.com>
Signed-off-by: Will Madden <madden@prisma.io>
@coderabbitai

coderabbitai Bot commented Aug 13, 2026

Copy link
Copy Markdown

Warning

Review limit reached

@wmadden-electric, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 77 minutes

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Organization UI

Review profile: ASSERTIVE

Plan: Pro Plus

Run ID: 80cd36e4-d031-4f59-b50a-d5394b2846b1

📥 Commits

Reviewing files that changed from the base of the PR and between 55193f7 and 6f01ae0.

📒 Files selected for processing (15)
  • packages/cli-engine/src/config-loader.ts
  • packages/cli-engine/src/exports/index.ts
  • packages/cli-engine/tests/config.test.ts
  • packages/cli-engine/tests/engine.test.ts
  • packages/cli-engine/tests/fixtures/config/env-block/prisma.config.ts
  • packages/cli-engine/tests/fixtures/config/env-overlay/prisma.config.ts
  • packages/cli-engine/tests/fixtures/config/extends-key/prisma.config.ts
  • packages/cli-engine/tests/fixtures/config/extends-remote/prisma.config.ts
  • packages/cli-engine/tests/fixtures/config/marked/prisma.config.ts
  • packages/cli-engine/tests/fixtures/config/meta-key/prisma.config.ts
  • packages/cli-engine/tests/fixtures/config/named/elsewhere.config.ts
  • packages/cli-engine/tests/fixtures/config/passthrough/prisma.config.ts
  • packages/cli-engine/tests/fixtures/config/proto-key/prisma.config.ts
  • packages/cli/tests/fixtures/config/composer-section.config.ts
  • packages/cli/tests/fixtures/config/elsewhere.config.ts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@pkg-pr-new

pkg-pr-new Bot commented Aug 13, 2026

Copy link
Copy Markdown

Open in StackBlitz

npx https://pkg.pr.new/@prisma/cli@173
npx https://pkg.pr.new/@prisma/cli-engine@173

commit: 6f01ae0

@wmadden
wmadden merged commit 9f14c86 into main Aug 13, 2026
13 checks passed
@wmadden
wmadden deleted the claude/define-prisma-config branch August 13, 2026 13:31
This was referenced Aug 13, 2026
wmadden pushed a commit that referenced this pull request Aug 13, 2026
Version bump `8.0.0-rc.1` → `8.0.0-rc.2` across the lockstep workspace,
produced by `pnpm bump-version` (lockfile regenerated in the same
commit; `pnpm install --frozen-lockfile` verified clean, full test suite
green).

## What ships

This is the release commit for the visual-system work now on main:

- #172 — engine-rendered help, renderer-owned output conventions
(section spacing, table conventions, colored diagnostics, did-you-mean,
dual-TTY mirror suppression), the ESM-resolver import fallback, e2e
hardening, and the output-gallery tooling.
- #173 — `definePrismaConfig` rename with deprecated `defineConfig`
alias.

## On merge

The publish workflow detects the root-version change and publishes
`@prisma/cli` and `@prisma/cli-engine` under the RC line's canonical
dist-tag `next`, creating the GitHub Release with tarballs attached.
Moving `latest` remains a separate manual `workflow_dispatch`.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

---------

Signed-off-by: willbot <w.a.madden+machine@gmail.com>
Signed-off-by: Will Madden <madden@prisma.io>
Co-authored-by: Claude Fable 5 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants