Rename the engine's defineConfig to definePrismaConfig - #173
Conversation
Every family ships a config helper named defineConfig — the engine's, the ORM's, composer's — so a prisma.config.ts that uses two of them has to alias imports. Unique names remove that: the engine's is now definePrismaConfig, and the CLI's own error prose names it. The old name stays exported as a deprecated alias so existing configs and the pinned family packages keep working; the ORM and composer helpers get their unique names in their own repos. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Signed-off-by: willbot <w.a.madden+machine@gmail.com> Signed-off-by: Will Madden <madden@prisma.io>
|
Warning Review limit reached
Next review available in: 77 minutes You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Organization UI Review profile: ASSERTIVE Plan: Pro Plus Run ID: 📒 Files selected for processing (15)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
commit: |
Version bump `8.0.0-rc.1` → `8.0.0-rc.2` across the lockstep workspace, produced by `pnpm bump-version` (lockfile regenerated in the same commit; `pnpm install --frozen-lockfile` verified clean, full test suite green). ## What ships This is the release commit for the visual-system work now on main: - #172 — engine-rendered help, renderer-owned output conventions (section spacing, table conventions, colored diagnostics, did-you-mean, dual-TTY mirror suppression), the ESM-resolver import fallback, e2e hardening, and the output-gallery tooling. - #173 — `definePrismaConfig` rename with deprecated `defineConfig` alias. ## On merge The publish workflow detects the root-version change and publishes `@prisma/cli` and `@prisma/cli-engine` under the RC line's canonical dist-tag `next`, creating the GitHub Release with tarballs attached. Moving `latest` remains a separate manual `workflow_dispatch`. 🤖 Generated with [Claude Code](https://claude.com/claude-code) --------- Signed-off-by: willbot <w.a.madden+machine@gmail.com> Signed-off-by: Will Madden <madden@prisma.io> Co-authored-by: Claude Fable 5 <noreply@anthropic.com>
What
Every command family ships a config helper named
defineConfig— the engine's (prisma.config.ts wrapper), the ORM's (@prisma/orm-postgres/config), composer's (@prisma/composer/config). A prisma.config.ts that composes two of them has to alias imports (import { defineConfig as ormConfig } ...). This gives the engine's helper a unique name:definePrismaConfig.defineConfigstays exported as a deprecated alias, so existing configs and the pinned family packages (orm-toolchain, composer, which bundle their own engine copies) keep working unchanged.CLI.CONFIG_MISSING_MARKER,CLI.CONFIG_VERSION_UNSUPPORTED) now namesdefinePrismaConfig.Cross-repo follow-ups (not this PR)
The same de-aliasing needs the other two helpers renamed in their own repos:
defineOrmConfigin prisma/prisma's@prisma/orm-*config packages, anddefineComposerConfigin@prisma/composer/config. (defineComputeConfigis already unique.)Testing
pnpm test(1,791 green),pnpm lint,pnpm typecheckall clean.🤖 Generated with Claude Code