feat(cli): add github repo connection foundation - #8
Merged
Conversation
|
Note Reviews pausedIt looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the Use the following commands to manage reviews:
Use the checkboxes below for quick actions:
WalkthroughThis PR adds a top-level ChangesGitHub Repository Connection Feature
🎯 4 (Complex) | ⏱️ ~60 minutes 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
✨ Simplify code
Comment |
AmanVarshney01
force-pushed
the
aman/github-repo-connection-cli
branch
from
May 18, 2026 15:22
0460d8d to
f456141
Compare
AmanVarshney01
marked this pull request as ready for review
May 19, 2026 12:33
There was a problem hiding this comment.
Actionable comments posted: 2
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@docs/product/command-spec.md`:
- Line 253: The current sentence stating "enables platform webhook automation to
map GitHub branch activity to Prisma Branch state" should be made conditional to
reflect that automation only runs when the repository connection is active;
update the sentence in command-spec.md (the line containing that exact phrase)
to explicitly include the condition (for example: "...enables platform webhook
automation to map GitHub branch activity to Prisma Branch state when the
repository connection is active" or similar wording), ensuring the documentation
clearly ties automation behavior to the repository connection state.
In `@packages/cli/src/presenters/project.ts`:
- Around line 91-94: The presenter's message for connection.status currently
maps any non-"active" value to "pending GitHub App installation", which
mislabels states like "archived"; update the logic in
packages/cli/src/presenters/project.ts (the code that builds the connection
message using connection.status) to explicitly handle known statuses (e.g.,
"pending" -> "GitHub branch automation is pending GitHub App installation",
"archived" -> "GitHub branch automation has been archived" or similar), and fall
back to a generic message for unknown statuses; implement this using a small
switch or mapping keyed by connection.status so each known status is rendered
correctly and unknown ones have a clear default.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: ASSERTIVE
Plan: Pro
Run ID: 00961753-9a94-4ecc-9e05-b55d3f6d08ae
📒 Files selected for processing (13)
docs/product/command-spec.mddocs/product/error-conventions.mddocs/product/output-conventions.mdpackages/cli/src/adapters/git.tspackages/cli/src/adapters/local-state.tspackages/cli/src/commands/project/index.tspackages/cli/src/controllers/project.tspackages/cli/src/presenters/project.tspackages/cli/src/shell/command-meta.tspackages/cli/src/types/project.tspackages/cli/tests/git-adapter.test.tspackages/cli/tests/project-real-mode.test.tspackages/cli/tests/project.test.ts
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@packages/cli/src/controllers/project.ts`:
- Around line 657-674: The pagination loops in project.ts (the do/while blocks
that use the cursor variable to fetch "/v1/scm-installations" and the similar
loop around lines 687-710) must guard against repeated cursors to avoid infinite
loops; add a Set (e.g., seenCursors) to record each cursor value before
requesting the next page, and when computing the next cursor (from
data.pagination.nextCursor) check if it's already in seenCursors—if so, break or
throw a descriptive error instead of continuing; update both the installations
loop (where installations.push(...data.data) is used and cursor is set) and the
second pagination loop to use this same defensive check.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: ASSERTIVE
Plan: Pro
Run ID: 88a7abe3-ab3f-4bac-82f0-125cf304dbab
📒 Files selected for processing (3)
docs/product/command-spec.mdpackages/cli/src/controllers/project.tspackages/cli/tests/project-real-mode.test.ts
luanvdw
reviewed
May 20, 2026
luanvdw
left a comment
Member
There was a problem hiding this comment.
@AmanVarshney01 I've been playing around with these commands, and was wondering if we could simplify the verbiage here? Instead of using,
prisma project connect-repo [git url]
prisma project disconnect-repo
we could bring git into the command like this
prisma project git connect [git url]
prisma project git disconnect
There was a problem hiding this comment.
Actionable comments posted: 1
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
packages/cli/src/controllers/project.ts (1)
166-169:⚠️ Potential issue | 🟠 Major | ⚡ Quick winPreserve real-mode idempotency semantics in fixture mode.
Line 169 always overwrites the stored connection. That makes fixture mode diverge from real mode: re-running
git connectfor the same repo should be a no-op, and connecting a different repo should raiseREPO_ALREADY_CONNECTEDinstead of silently replacing state.Suggested fix
const target = await resolveProjectShowInFixtureMode(context, workspace, options.project); const repository = await resolveRepositoryForConnect(context, gitUrl); + const existingConnection = await context.stateStore.readRepositoryConnection(target.project.id); + + if (existingConnection) { + if (repositoryFullNamesMatch(existingConnection.repository.fullName, repository.fullName)) { + return { + command: "git.connect", + result: { + ...target, + repositoryConnection: existingConnection, + }, + warnings: [], + nextSteps: [], + }; + } + + throw repoAlreadyConnectedError(existingConnection.repository.fullName); + } + const connection = createPendingRepositoryConnection(repository); await context.stateStore.setRepositoryConnection(target.project.id, connection);🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@packages/cli/src/controllers/project.ts` around lines 166 - 169, The code always overwrites the stored connection (context.stateStore.setRepositoryConnection) causing fixture mode to diverge from real mode; change it to first read the existing connection for target.project.id (e.g., via context.stateStore.getRepositoryConnection) and: if no existing connection, call createPendingRepositoryConnection(repository) and set it; if an existing connection points to the same repository (compare repository.id or gitUrl) treat it as a no-op; if it points to a different repository throw the same REPO_ALREADY_CONNECTED error the real path would raise. Use the existing symbols resolveProjectShowInFixtureMode, resolveRepositoryForConnect, createPendingRepositoryConnection, target.project.id and connection to locate and implement this check.
♻️ Duplicate comments (3)
docs/product/command-spec.md (1)
254-254:⚠️ Potential issue | 🟡 Minor | ⚡ Quick winMake automation enablement conditional in the behavior docs.
The current statement is absolute, but automation is only active when the repository connection is in an active state. The documentation should reflect this conditionality to avoid confusion about when webhook automation actually runs.
📝 Suggested wording
-- enables platform webhook automation to map GitHub branch activity to Prisma Branch state +- when the connection is active, enables platform webhook automation to map GitHub branch activity to Prisma Branch state🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@docs/product/command-spec.md` at line 254, Update the absolute sentence "enables platform webhook automation to map GitHub branch activity to Prisma Branch state" so it reflects conditional activation; change it to indicate that webhook automation runs only when the repository connection is in an active state (e.g., "enables platform webhook automation to map GitHub branch activity to Prisma Branch state when the repository connection is active"), and ensure any related phrasing nearby in command-spec.md uses the same conditional language to avoid inconsistency.packages/cli/src/presenters/project.ts (1)
90-94:⚠️ Potential issue | 🟡 Minor | ⚡ Quick winHandle
archivedseparately in connect output.Line 93 currently labels every non-
activeconnection as “pending GitHub App installation”. The controller can also returnarchived, so archived repositories will be shown with the wrong state.🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@packages/cli/src/presenters/project.ts` around lines 90 - 94, The current presenter builds the details array using connection.status and treats any non-"active" value as "pending GitHub App installation"; update the logic that sets details (where connection.status is checked) to explicitly handle "archived" (e.g., if connection.status === "archived" show a message like "GitHub branch automation is archived for this project.") and keep the existing messages for "active" and the fallback; locate the condition around connection.status in the presenter (the details array construction) and add an explicit branch for "archived" instead of the current binary active/else branch.packages/cli/src/controllers/project.ts (1)
650-674:⚠️ Potential issue | 🟠 Major | ⚡ Quick winGuard both pagination loops against non-advancing cursors.
Lines 673 and 709 still trust
nextCursorprogression completely. If the API repeats a cursor whilehasMorestays true,git connectcan hang indefinitely during installation or repository lookup.Also applies to: 679-710
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@packages/cli/src/controllers/project.ts` around lines 650 - 674, The pagination loop in listScmInstallations trusts pagination.nextCursor to always advance and can hang if the API returns the same cursor repeatedly; update listScmInstallations to detect non-advancing cursors by tracking the previous cursor (e.g., prevCursor) and comparing it to the nextCursor returned from data.pagination.nextCursor, and if nextCursor is equal to prevCursor (or otherwise not changing) while hasMore is true, break and surface/throw a descriptive repoConnectionApiError instead of looping indefinitely; apply the same guard to the other pagination loop that uses cursor/nextCursor so both loops bail on non-progressing cursors.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@docs/product/command-spec.md`:
- Line 19: Change the lowercase "github" to the proper noun "GitHub" in the docs
string "provider-specific `github` group." — update the markdown so the phrase
reads "provider-specific `GitHub` group" (preserve backticks/inline code
formatting) wherever that exact snippet or symbol appears in the document.
---
Outside diff comments:
In `@packages/cli/src/controllers/project.ts`:
- Around line 166-169: The code always overwrites the stored connection
(context.stateStore.setRepositoryConnection) causing fixture mode to diverge
from real mode; change it to first read the existing connection for
target.project.id (e.g., via context.stateStore.getRepositoryConnection) and: if
no existing connection, call createPendingRepositoryConnection(repository) and
set it; if an existing connection points to the same repository (compare
repository.id or gitUrl) treat it as a no-op; if it points to a different
repository throw the same REPO_ALREADY_CONNECTED error the real path would
raise. Use the existing symbols resolveProjectShowInFixtureMode,
resolveRepositoryForConnect, createPendingRepositoryConnection,
target.project.id and connection to locate and implement this check.
---
Duplicate comments:
In `@docs/product/command-spec.md`:
- Line 254: Update the absolute sentence "enables platform webhook automation to
map GitHub branch activity to Prisma Branch state" so it reflects conditional
activation; change it to indicate that webhook automation runs only when the
repository connection is in an active state (e.g., "enables platform webhook
automation to map GitHub branch activity to Prisma Branch state when the
repository connection is active"), and ensure any related phrasing nearby in
command-spec.md uses the same conditional language to avoid inconsistency.
In `@packages/cli/src/controllers/project.ts`:
- Around line 650-674: The pagination loop in listScmInstallations trusts
pagination.nextCursor to always advance and can hang if the API returns the same
cursor repeatedly; update listScmInstallations to detect non-advancing cursors
by tracking the previous cursor (e.g., prevCursor) and comparing it to the
nextCursor returned from data.pagination.nextCursor, and if nextCursor is equal
to prevCursor (or otherwise not changing) while hasMore is true, break and
surface/throw a descriptive repoConnectionApiError instead of looping
indefinitely; apply the same guard to the other pagination loop that uses
cursor/nextCursor so both loops bail on non-progressing cursors.
In `@packages/cli/src/presenters/project.ts`:
- Around line 90-94: The current presenter builds the details array using
connection.status and treats any non-"active" value as "pending GitHub App
installation"; update the logic that sets details (where connection.status is
checked) to explicitly handle "archived" (e.g., if connection.status ===
"archived" show a message like "GitHub branch automation is archived for this
project.") and keep the existing messages for "active" and the fallback; locate
the condition around connection.status in the presenter (the details array
construction) and add an explicit branch for "archived" instead of the current
binary active/else branch.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: ASSERTIVE
Plan: Pro
Run ID: 0fa9c47f-7149-443d-ab55-ee18d4d4f82f
📒 Files selected for processing (10)
docs/product/command-principles.mddocs/product/command-spec.mddocs/product/output-conventions.mdpackages/cli/src/cli.tspackages/cli/src/commands/git/index.tspackages/cli/src/controllers/project.tspackages/cli/src/presenters/project.tspackages/cli/src/shell/command-meta.tspackages/cli/tests/project-real-mode.test.tspackages/cli/tests/project.test.ts
There was a problem hiding this comment.
Actionable comments posted: 1
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
docs/product/command-spec.md (1)
261-261:⚠️ Potential issue | 🟡 Minor | ⚡ Quick winSimplify and standardize the mode terminology.
The phrase "non-interactive mode, JSON mode, or CI" should be simplified to "non-interactive or
--jsonmode" for consistency with terminology used elsewhere in this document (e.g., lines 45, 73). "CI" is redundant since CI environments typically run with--no-interactive, and "JSON mode" should be styled as--jsonmode with backticks.📝 Proposed fix
-in non-interactive mode, JSON mode, or CI, the CLI exits with `REPO_INSTALLATION_REQUIRED` and includes the install URL +in non-interactive or `--json` mode, the CLI exits with `REPO_INSTALLATION_REQUIRED` and includes the install URL🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@docs/product/command-spec.md` at line 261, Replace the phrase "non-interactive mode, JSON mode, or CI" with "non-interactive or `--json` mode" and style `--json` with backticks for consistency; update the sentence that reads about exiting with `REPO_INSTALLATION_REQUIRED` so it now says the CLI exits in non-interactive or `--json` mode with `REPO_INSTALLATION_REQUIRED` and includes the install URL, removing the redundant "CI" wording.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@packages/cli/tests/project.test.ts`:
- Around line 293-355: Read and store the repository connection object
immediately after the first successful connect by calling readFile on
path.join(stateDir, "state.json") and saving
state.project.repositoryConnectionsByProject.proj_123 into a variable (e.g.,
initialConnection); then in the same-repo test compare that initialConnection
against the parsed JSON result from the second executeCli call and against the
final state.json to ensure deep equality (no fields like connectedAt were
rewritten); apply the same pattern in the replacement test to assert the stored
object remains exactly the initialConnection when a conflicting connect fails.
---
Outside diff comments:
In `@docs/product/command-spec.md`:
- Line 261: Replace the phrase "non-interactive mode, JSON mode, or CI" with
"non-interactive or `--json` mode" and style `--json` with backticks for
consistency; update the sentence that reads about exiting with
`REPO_INSTALLATION_REQUIRED` so it now says the CLI exits in non-interactive or
`--json` mode with `REPO_INSTALLATION_REQUIRED` and includes the install URL,
removing the redundant "CI" wording.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: ASSERTIVE
Plan: Pro
Run ID: 6dae6461-003d-47ea-a59e-2c9dc05393bf
📒 Files selected for processing (3)
docs/product/command-spec.mdpackages/cli/src/controllers/project.tspackages/cli/tests/project.test.ts
luanvdw
previously approved these changes
May 20, 2026
wmadden-electric
added a commit
that referenced
this pull request
Aug 12, 2026
…k its only ones Removing the fixture-mode tests removed the only coverage of `renderAuthSuccess` with it: no test file referenced it afterwards. The rendering is real behaviour that users see, so losing its tests along with the mode that happened to reach it was a regression, not a cleanup. It is tested directly now rather than through whichever command calls it: the login rows, the rows omitted when there is no provider, user or workspace, the service-token labels for a credential with and without a name, signed-out, and the logout line. Not addressed, with a reason: review also asked for the Git flow in `runGitConnect` to use the generated SDK client instead of `client as unknown as SourceRepositoryApiClient` and a hand-written method contract. That cast arrived in #8 and this branch only reindented it while unwrapping a fixture branch. Replacing it means checking whether the published SDK covers the source-repository paths at all, which is its own change. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Signed-off-by: willbot <w.a.madden+machine@gmail.com> Signed-off-by: Will Madden <madden@prisma.io>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
summary
adds the cli foundation for connecting a resolved prisma project to a github repository through the server-side github app installation flow.
prisma git connect [git-url]prisma git disconnectgit remote originwhen no url is passed--project <id-or-name>REPO_INSTALLATION_REQUIREDwith the install url in json, ci, or non-interactive modePOST /v1/source-repositorieswithprojectId,providerRepositoryId, andinstallationIdgit connectruns idempotent when the project is already linked to the same repocli examples
not included