Skip to content

Fix seed ts compile options - Add tab section for mac and windows examples - #2324

Closed
elsangedy wants to merge 1 commit into
prisma:mainfrom
elsangedy:patch-1
Closed

Fix seed ts compile options - Add tab section for mac and windows examples#2324
elsangedy wants to merge 1 commit into
prisma:mainfrom
elsangedy:patch-1

Conversation

@elsangedy

Copy link
Copy Markdown

No description provided.

```ts
"prisma": {
"seed": "ts-node --compiler-options \"{\\\"module\\\":\\\"commonjs\\\"}\" prisma/seed.ts"
"seed": "ts-node --compiler-options {\"module\":\"commonjs\"} prisma/seed.ts"

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not confident this would work on Windows out of the box.

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The current documentation doesn't work for macos.
Maybe we can put these two options? (for windows, for unix)

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The current documentation was chosen as it was supposed to work on all platforms. If that is not the case any more, we need to find an option that does.

Is there an issue for this not working?

@molebox molebox changed the title Fix seed ts compile options Fix seed ts compile options - Add tab section for mac and windows examples Sep 16, 2021
@Jolg42

Jolg42 commented Sep 22, 2021

Copy link
Copy Markdown
Contributor

Closing because duplicate, done with #2338 https://prisma-company.slack.com/archives/CGMCB82N8/p1631898183074400

@Jolg42 Jolg42 closed this Sep 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants