Add docs on Data Proxy directUrl property by keerlu · Pull Request #4377 · prisma/web

keerlu · 2023-01-10T10:42:44Z

Describe this PR

Add Data Proxy directUrl property to datasource block in schema reference
Update Data Proxy page on introspect/migrate/CLI commands

Changes

What issue does this fix?

Fixes #4297
Fixes #4305

Any other relevant information

vercel · 2023-01-10T10:42:48Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated
docs	✅ Ready (Inspect)	Visit Preview	💬 Add your feedback	Feb 7, 2023 at 7:26PM (UTC)

github-actions · 2023-01-10T10:43:00Z

This PR changes the following pages (Vercel Preview Deploy links):

Changed Vercel links

(Note that links will only be valid after Vercel preview deploy succeeded)

janpio · 2023-01-10T20:01:23Z

Note that we already have a shortlink pointing to this section, which seem to have broken in an earlier update when the headline/anchor was renamed: https://pris.ly/d/data-proxy-cli We should make sure we have a good headline to link to that can be updated via a PR to pris.ly

…ata-proxy.mdx Co-authored-by: Jan Piotrowski <piotrowski+github@gmail.com>

keerlu · 2023-01-11T09:45:50Z

This seems to be the place the shortlink is used: https://sourcegraph.com/github.com/prisma/prisma/-/blob/packages/internals/src/cli/checkUnsupportedDataProxy.ts?L37

I think linking to this whole page, rather than a heading, would work, as is the message is about the general problem with needing to use a direct connection

janpio · 2023-01-11T15:59:12Z

True, before this was just a subsection of a page - not it is its own page.
Then we only need to remove the anchor from the pris.ly config to avoid this confusion moving forward.

zachtil · 2023-01-12T23:15:19Z

Thank you for helping with this content, @keerlu! 🙏 That is going to make things so much easier for Data Proxy users! 😌

Closes #1359 Note: docs PR prisma/web#4377

sabinadams

All of this looks good to me

janpio · 2023-02-04T12:08:12Z

 Currently, you can only use [Prisma Client](/concepts/components/prisma-client) with the Data Proxy to _query_ your database.

-</TopBlock>
-
+You need a direct (non-Data Proxy) database connection if you apply schema changes to your database with [Prisma Migrate](/concepts/components/prisma-migrate/get-started) or [`db push`](/concepts/components/prisma-migrate/db-push), or if you [introspect](/concepts/components/introspection) your database. See [Prisma CLI commands that require a direct database connection](#prisma-cli-commands-that-require-a-direct-database-connection).


Upon rereading this, we could make clearer that Prisma Client is totally fine.
And that it is only Prisma CLI where commands are not by default and the additional feature here are needed.
Right now that is not super spelled out, both in words and visually.

(Line 12 could maybe start with "In Prisma CLI you need...")

amlcodes · 2023-02-07T21:10:05Z

prisma:warn Attempt 1/10 failed for querying: Internal Data Proxy error (The request id was: 84981ec9bae4ff43536662429f743c00)

This reverts commit 453eb89.

Update schema reference

fe70289

vercel Bot deployed to Preview January 10, 2023 10:47 View deployment

keerlu marked this pull request as draft January 10, 2023 11:10

keerlu changed the title ~~Add Data Proxy directUrl property to schema reference~~ Add docs on Data Proxy directUrl property Jan 10, 2023

Merge branch 'main' into direct-url

8817b32

vercel Bot deployed to Preview January 10, 2023 11:17 View deployment

janpio reviewed Jan 10, 2023

View reviewed changes

Comment thread content/400-reference/200-api-reference/100-prisma-schema-reference.mdx Outdated

Update CLI commands with Data Proxy page

010c7cd

keerlu marked this pull request as ready for review January 10, 2023 14:33

vercel Bot deployed to Preview January 10, 2023 14:38 View deployment

janpio reviewed Jan 10, 2023

View reviewed changes

Comment thread content/800-data-platform/050-data-proxy/700-prisma-cli-with-data-proxy.mdx Outdated

janpio reviewed Jan 10, 2023

View reviewed changes

Comment thread content/800-data-platform/050-data-proxy/700-prisma-cli-with-data-proxy.mdx Outdated

Update content/800-data-platform/050-data-proxy/700-prisma-cli-with-d…

bb69e69

…ata-proxy.mdx Co-authored-by: Jan Piotrowski <piotrowski+github@gmail.com>

vercel Bot deployed to Preview January 11, 2023 09:38 View deployment

Merge branch 'main' into direct-url

79f36f5

vercel Bot deployed to Preview January 11, 2023 09:52 View deployment

zachtil reviewed Jan 12, 2023

View reviewed changes

Comment thread content/400-reference/200-api-reference/100-prisma-schema-reference.mdx Outdated

zachtil approved these changes Jan 12, 2023

View reviewed changes

Remove firewall admonition

662103f

vercel Bot deployed to Preview January 13, 2023 10:07 View deployment

Lucy Keer added 2 commits January 13, 2023 10:15

Update directUrl argument description

945bf7e

Move list of commands to its own section

da33132

vercel Bot deployed to Preview January 13, 2023 10:29 View deployment

Jolg42 added this to the 4.9.0 milestone Jan 16, 2023

Jolg42 reviewed Jan 16, 2023

View reviewed changes

Comment thread content/400-reference/200-api-reference/100-prisma-schema-reference.mdx Outdated

janpio approved these changes Jan 17, 2023

View reviewed changes

Link to list of commands

965d494

vercel Bot deployed to Preview January 17, 2023 09:35 View deployment

janpio modified the milestones: 4.9.0, 4.10.0 Jan 18, 2023

Jolg42 added a commit to prisma/language-tools that referenced this pull request Jan 26, 2023

feat: add directUrl completion

a4d1eaa

Closes #1359 Note: docs PR prisma/web#4377

Jolg42 mentioned this pull request Jan 26, 2023

feat: add directUrl completion + better datasource/generator completions prisma/language-tools#1370

Merged

sabinadams approved these changes Feb 2, 2023

View reviewed changes

janpio assigned sabinadams Feb 2, 2023

Merge branch 'main' into direct-url

d4c27a0

janpio reviewed Feb 4, 2023

View reviewed changes

vercel Bot deployed to Preview February 4, 2023 12:13 View deployment

Revises a sentence for clarity

1ad2ee9

vercel Bot deployed to Preview February 6, 2023 18:37 View deployment

Merge branch 'main' into direct-url

1eedb80

vercel Bot deployed to Preview February 7, 2023 19:01 View deployment

ruheni added 2 commits February 7, 2023 20:07

Merge branch 'main' into direct-url

cab2e83

Merge branch 'main' into direct-url

050576b

vercel Bot deployed to Preview February 7, 2023 19:18 View deployment

Merge branch 'main' into direct-url

d05d111

ruheni merged commit 453eb89 into main Feb 7, 2023

ruheni deleted the direct-url branch February 7, 2023 19:22

vercel Bot deployed to Preview February 7, 2023 19:26 View deployment

janpio added a commit that referenced this pull request Feb 8, 2023

Revert "Add docs on Data Proxy directUrl property (#4377)"

d3fc516

This reverts commit 453eb89.

janpio mentioned this pull request Feb 8, 2023

Revert "Add docs on Data Proxy directUrl property" #4504

Merged

Uh oh!

Conversation

keerlu commented Jan 10, 2023 • edited by zachtil Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Describe this PR

Changes

What issue does this fix?

Any other relevant information

Uh oh!

vercel Bot commented Jan 10, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented Jan 10, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

janpio commented Jan 10, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

keerlu commented Jan 11, 2023

Uh oh!

janpio commented Jan 11, 2023

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

zachtil commented Jan 12, 2023

Uh oh!

Uh oh!

sabinadams left a comment

Choose a reason for hiding this comment

Uh oh!

janpio Feb 4, 2023

Choose a reason for hiding this comment

Uh oh!

amlcodes commented Feb 7, 2023

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

keerlu commented Jan 10, 2023 •

edited by zachtil

Loading

vercel Bot commented Jan 10, 2023 •

edited

Loading

github-actions Bot commented Jan 10, 2023 •

edited

Loading

janpio commented Jan 10, 2023 •

edited

Loading