Updated Code for instantiating single PrismaClient instance - #4478
Merged
Conversation
The current code snippet was using outdated NodeJS.Global interface that was removed in Node version 16. The new snippet is used from our related Help Article for the same topic: https://www.prisma.io/docs/guides/database/troubleshooting-orm/help-articles/nextjs-prisma-client-dev-practices
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Contributor
|
This PR changes the following pages (Vercel Preview Deploy links): Changed Vercel links (Note that links will only be valid after Vercel preview deploy succeeded) |
sabinadams
suggested changes
Feb 3, 2023
Contributor
There was a problem hiding this comment.
@nurul3101 Overall looked great! Just one question about the logging added to Prisma Client.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe this PR
The current code snippet was using outdated
NodeJS.Globalinterface that was removed in Node version 16.The new snippet is used from our related Help Article for the same topic: https://www.prisma.io/docs/guides/database/troubleshooting-orm/help-articles/nextjs-prisma-client-dev-practices
Changes
Refactored code snippet
What issue does this fix?
Fixes Outdated code snippet that doesn't work in node version > 16