chore: add client extensions examples to existing Prisma Client sections - #4515
Closed
ruheni wants to merge 58 commits into
Closed
chore: add client extensions examples to existing Prisma Client sections#4515ruheni wants to merge 58 commits into
ruheni wants to merge 58 commits into
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Contributor
- add logging, exists function, custom validation extensions - rename file names to re-order priority
…com:prisma/docs into client-extensions
ruheni
commented
Feb 17, 2023
…t-extensions/202-exists-function.mdx
ruheni
commented
Feb 17, 2023
…t-extensions/202-exists-function.mdx
ruheni
commented
Feb 17, 2023
…t-extensions/202-exists-function.mdx
ruheni
marked this pull request as ready for review
February 17, 2023 10:36
nikolasburk
suggested changes
Apr 25, 2023
nikolasburk
left a comment
Contributor
There was a problem hiding this comment.
looks great, I've left a few small comments but once there are incorporated, this is ready to merge 🚀
| <tab> | ||
|
|
||
| ```ts copy | ||
| // A post with invalid input — missing the title field |
Contributor
There was a problem hiding this comment.
it's nice that you're showing an example query here, but I don't find it too helpful without further context and hidden in the tabs. how is it going to help someone reading this page understand validation better?
it would be more helpful IMO if:
- the query wasn't hidden in a tab
- there were two scenarios shown: one with a valid input one another one with an invalid input, including an explanation of the expected error
Co-authored-by: Nikolas <nikolas.burk@gmail.com>
This reverts commit e19d6a8.
Co-authored-by: Nikolas <nikolas.burk@gmail.com>
Co-authored-by: Nikolas <nikolas.burk@gmail.com>
…o client-extensions
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe this PR
Closes #4481
Add Prisma Client extension examples to existing workarounds:
Show an example with Prisma Client Extensions on the page
Removed from the PR
existsfunctionJSON field type validationsoft delete(Update when support for nesting is added)query loggingsession data(RLS?)RLSMove PCE a level above Middleware?Set up redirects for old pagesExamples marked with
~~are currently out of scope for v1.Alternative idea:
Convert the Prisma Client extensions GH repo to resemble the Prisma Examples repo — in terms of structure and purpose.
The repository can serve as a reference + dump for PCE ideas + contributions from other users.
Create a page to aggregate the list of all extensions in the repository — name and descriptions
Note: Closed in favor of #4719