fix: update scrollbar for code blocks - #4785
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Contributor
Contributor
|
This PR probably requires the following redirects to be added to vercel.json:
|
nilubava
reviewed
May 30, 2023
meletj
approved these changes
Jun 1, 2023
Contributor
Contributor
Contributor
|
I believe this would also fix this issue #1446 ie it looks like the wrap option was a request already. |
Contributor
|
The |
ruheni
approved these changes
Jun 12, 2023
carlagn
force-pushed
the
fix/codeblock-scrollbar
branch
from
June 15, 2023 14:33
44b5f75 to
362195e
Compare
nilubava
approved these changes
Jun 15, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe this PR
Horizontal scrollbar for code blocks is not currently uniformed in behaviour or appearance.
Changes
Update
codecomponent to have a generalised scrollbar look and behaviour, one which is already in place at @prisma/blog as well.Added
wrapprop on codeblock components for cases where we have code blocks that have only one line or we want to wrap the text depending on the context.i.e. in cases such as this code block, it wouldn't make sense to have the full line scrollable, since it'd just make it harder to read or copy.
For #1015:
For #1023 We changed the behaviour to always display a scrollbar in case it contains large code inside. As it is now, the user needs to scroll inside to make the scrollbar visible, but it is not 100% obvious it is a codeblock with large content.
What issue does this fix?
Fixes #1023 #1015
Any other relevant information
N/a