Improve excluding fields example to not mutate data - #4794
Merged
Conversation
The previous implementation mutated the passed object. This updated version does not. The issue here is that in this example `password` is deleted from the passed object, `user`, causing a call to password to fail after exclude is called. E.G.: `user.password.trim()` would fail with "cannot call 'trim' on 'undefined'".
|
@squirly is attempting to deploy a commit to the Prisma Team on Vercel. A member of the Team first needs to authorize it. |
millsp
approved these changes
Jun 20, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe this PR
The current implementation of
excludein the docs mutates the passed object. The issue here is that in the examplepasswordis deleted from the passed object,user, causing a call to password to fail after exclude is called. E.G.:user.password.trim()would fail with "cannot call 'trim' on 'undefined'".Changes
The updated version does not have this issue.