fix(env): Remove section about having to use dotenv to use env vars in code - #4860
Closed
janpio wants to merge 3 commits into
Closed
fix(env): Remove section about having to use dotenv to use env vars in code#4860janpio wants to merge 3 commits into
janpio wants to merge 3 commits into
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Contributor
|
This PR changes the following pages (Vercel Preview Deploy links): Changed Vercel links (Note that links will only be valid after Vercel preview deploy succeeded) |
Contributor
|
This PR probably requires the following redirects to be added to vercel.json:
|
millsp
approved these changes
Jun 7, 2023
Contributor
|
The removal is correct, but I am not sure this closes the mentioned issue? The person is complaining that Prisma Client loads and pollutes their env although it shouldn't (I think we have multiple reports of that?). |
Contributor
Author
|
Yes, as you say we have other issues about that. This user was mostly misguided by the docs that tell them otherwise - so fixing the docs solves their immediate complaint. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
.envfile is automatically loaded, so nodotenvneeded.closes prisma/orm#19519