Skip to content

feat(frontmatter): Document required vs. optional frontmatter - #4916

Closed
janpio wants to merge 3 commits into
mainfrom
janpio-patch-21
Closed

feat(frontmatter): Document required vs. optional frontmatter#4916
janpio wants to merge 3 commits into
mainfrom
janpio-patch-21

Conversation

@janpio

@janpio janpio commented Jun 14, 2023

Copy link
Copy Markdown
Contributor

@vercel

vercel Bot commented Jun 14, 2023

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jun 15, 2023 8:38am

@github-actions

Copy link
Copy Markdown
Contributor

This PR changes the following pages (Vercel Preview Deploy links):

Changed Vercel links

(Note that links will only be valid after Vercel preview deploy succeeded)

@github-actions

Copy link
Copy Markdown
Contributor

This PR probably requires the following redirects to be added to vercel.json:

  • This PR does not change any pages in a way that would require a redirect.

Comment thread content/600-about/200-prisma-docs/30-docs-components/03-frontmatter.mdx Outdated

@meletj meletj left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall LGTM. I'll let Nilu take a second look too.
I think we could adjust this to use 'you' instead of 'we' . If we wish, we can make the metaTitle more descriptive than the title.

@janpio

janpio commented Nov 15, 2023

Copy link
Copy Markdown
Contributor Author

Unfortunately seems that the frontmatter page was changed too much so there is now a conflict. This will need to be re-applied to the current state @nilubava, @carlagn, @meletj.

@nikolasburk

Copy link
Copy Markdown
Contributor

Yeah, I tried to go through it in the web editor but wasn't able to properly resolve everything. Let's defer 🙏

@janpio

janpio commented Nov 24, 2023

Copy link
Copy Markdown
Contributor Author

Reordering is almost impossible to get right here in the GitHub UI. I think someone will need to look at the preview of this, resort the current state of the frontmatter page, and then add the same headlines as here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants