MSSQL: use database in connection string instead of initialCatalog - #4978
Merged
Conversation
|
@manuel3108 is attempting to deploy a commit to the Prisma Team on Vercel. A member of the Team first needs to authorize it. |
ruheni
self-requested a review
July 17, 2023 15:28
ruheni
approved these changes
Jul 18, 2023
ruheni
left a comment
Contributor
There was a problem hiding this comment.
Thank you for catching that @manuel3108. 🙌
Here's a link to SQL Server's docs for more context: https://learn.microsoft.com/en-us/sql/connect/jdbc/setting-the-connection-properties?view=sql-server-ver16#:~:text=databaseName%2C%0Adatabase — for anyone else who is curious why
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe this PR
For Microsoft SQL Server the documentation is inconsistent for using
databaseorinitialCatalog. I gues this was changed recently, but only the first occurrence gut corrected.Currently for me, using
initialCatalogdoes not seem to work. At least for an hosted Azure SQL Database. After many hours of debugging and enabling debug logs, i could see that it was not correctly changing the database. I always got different errros, mostly that my database was empty.After a lot of reasearch i pinpointed, that I apparently copied the connection string with the sample data, which currently uses
initialConnectionChanges
Use
databasein all provided MSSQL connection stringsWhat issue does this fix?
Documentation inconsistency
Any other relevant information
--