Skip to content

MSSQL: use database in connection string instead of initialCatalog - #4978

Merged
ruheni merged 2 commits into
prisma:mainfrom
manuel3108:patch-1
Jul 18, 2023
Merged

MSSQL: use database in connection string instead of initialCatalog#4978
ruheni merged 2 commits into
prisma:mainfrom
manuel3108:patch-1

Conversation

@manuel3108

Copy link
Copy Markdown
Contributor

Describe this PR

For Microsoft SQL Server the documentation is inconsistent for using database or initialCatalog. I gues this was changed recently, but only the first occurrence gut corrected.

Currently for me, using initialCatalog does not seem to work. At least for an hosted Azure SQL Database. After many hours of debugging and enabling debug logs, i could see that it was not correctly changing the database. I always got different errros, mostly that my database was empty.

After a lot of reasearch i pinpointed, that I apparently copied the connection string with the sample data, which currently uses initialConnection

Changes

Use database in all provided MSSQL connection strings

What issue does this fix?

Documentation inconsistency

Any other relevant information

--

@vercel

vercel Bot commented Jun 25, 2023

Copy link
Copy Markdown

@manuel3108 is attempting to deploy a commit to the Prisma Team on Vercel.

A member of the Team first needs to authorize it.

@ruheni
ruheni self-requested a review July 17, 2023 15:28

@ruheni ruheni left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for catching that @manuel3108. 🙌

Here's a link to SQL Server's docs for more context: https://learn.microsoft.com/en-us/sql/connect/jdbc/setting-the-connection-properties?view=sql-server-ver16#:~:text=databaseName%2C%0Adatabase — for anyone else who is curious why

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants