Skip to content

fix: inline code boldness on headings - #5013

Closed
nilubava wants to merge 3 commits into
mainfrom
fix/inline-code-heading
Closed

fix: inline code boldness on headings#5013
nilubava wants to merge 3 commits into
mainfrom
fix/inline-code-heading

Conversation

@nilubava

@nilubava nilubava commented Jul 6, 2023

Copy link
Copy Markdown
Contributor

Describe this PR

Changes

What issue does this fix?

Any other relevant information

@vercel

vercel Bot commented Jul 6, 2023

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 25, 2023 8:29am

@github-actions

github-actions Bot commented Jul 6, 2023

Copy link
Copy Markdown
Contributor

This PR changes the following pages (Vercel Preview Deploy links):

Changed Vercel links

(Note that links will only be valid after Vercel preview deploy succeeded)

@github-actions

github-actions Bot commented Jul 6, 2023

Copy link
Copy Markdown
Contributor

This PR probably requires the following redirects to be added to vercel.json:

  • This PR does not change any pages in a way that would require a redirect.

@janpio

janpio commented Jul 6, 2023

Copy link
Copy Markdown
Contributor

I think in bigger headlines the code font-size is now a bit much:

  • image
  • image
  • image

@nilubava

nilubava commented Jul 6, 2023

Copy link
Copy Markdown
Contributor Author

@janpio Can you review again?

@janpio

janpio commented Jul 6, 2023

Copy link
Copy Markdown
Contributor

Now it is the same size as before, but bold - that is definitely better in that it does not add another design weirdness.

But the font size is probably too small really for a headline.

Examples:

  • image
  • image
  • image

@nilubava

nilubava commented Jul 7, 2023

Copy link
Copy Markdown
Contributor Author

@janpio If it is the same font, the it would look like the image in your first feedback.
image

@janpio

janpio commented Jul 7, 2023

Copy link
Copy Markdown
Contributor

I know, the code font is "visually bigger" - so if we want to tweak this, we'll probably have to play with the font-size a bit to adapt to all these use cases.

@nilubava nilubava linked an issue Jul 17, 2023 that may be closed by this pull request
@nilubava

Copy link
Copy Markdown
Contributor Author

A page where this occurs: https://www.prisma.io/docs/about/prisma-docs/about-the-docs#the-user-and-post-data-model

@janpio janpio added the website label Nov 15, 2023

@janpio janpio left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the bolding is already good.

Optimally we would also bump up the font size to match the rest of the text in the headlines, but that can be a separate PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Font boldness on heading inline code

3 participants