fix: List under admonition indentation - #5249
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Contributor
|
This PR changes the following pages (Vercel Preview Deploy links): Changed Vercel links (Note that links will only be valid after Vercel preview deploy succeeded) |
Contributor
|
This PR probably requires the following redirects to be added to vercel.json:
|
Contributor
|
If the bullet goes over two lines, the indentation is still off: |
carlagn
force-pushed
the
fix/admonition-list-indentation
branch
from
September 12, 2023 10:47
eb04847 to
b2c98d5
Compare
nilubava
approved these changes
Sep 12, 2023
Contributor
meletj
approved these changes
Sep 12, 2023
carlagn
pushed a commit
that referenced
this pull request
Sep 15, 2023
* Add margins to lists under admonition components * Update individual list item's margin-top * Update admonition to list on wrapper * Update theme import for admonition file * Update admonition indentation of relations page * Update indentation of lists under admonition
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Describe this PR
Lists inside Admonition components do not get the same margins as a regular list on the body.
Changes
Added
margin-left,margin-top, andmargin-bottomto lists rendered under theAdmonitioncomponent.What issue does this fix?
Fixes #4891
Any other relevant information
N/a