Skip to content

Docusaurus: fix:DA-167 remove last breadcrumb #5782

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
carlagn merged 2 commits into from
Apr 2, 2024
Merged

Docusaurus: fix:DA-167 remove last breadcrumb #5782

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
dd571ca
remove last item of breadcrumb
Apr 2, 2024
2211ab7
update length min
Apr 2, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 4 additions & 11 deletions src/theme/DocBreadcrumbs/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,15 +10,8 @@ import {translate} from '@docusaurus/Translate';
import HomeBreadcrumbItem from '@theme/DocBreadcrumbs/Items/Home';
import styles from './styles.module.css';
// TODO move to design system folder
function BreadcrumbsItemLink({children, href, isLast}) {
function BreadcrumbsItemLink({children, href}) {
const className = 'breadcrumbs__link';
if (isLast) {
return (
<span className={className} itemProp="name">
{children}
</span>
);
}
return href ? (
<Link className={className} href={href} itemProp="item">
<span itemProp="name">{children}</span>
Expand Down Expand Up @@ -73,7 +66,7 @@ export default function DocBreadcrumbs() {
message: 'Breadcrumbs',
description: 'The ARIA label for the breadcrumbs',
})}>
{repeatedBreadcrumbs() && <ul
{repeatedBreadcrumbs() && breadcrumbs.length > 1 && <ul
className="breadcrumbs"
itemScope
itemType="https://schema.org/BreadcrumbList">
Expand All @@ -84,13 +77,13 @@ export default function DocBreadcrumbs() {
item.type === 'category' && item.linkUnlisted
? undefined
: item.href;
return (
return ( !isLast &&
<BreadcrumbsItem
key={idx}
active={isLast}
index={idx}
addMicrodata={!!href}>
<BreadcrumbsItemLink href={href} isLast={isLast}>
<BreadcrumbsItemLink href={href}>
{item.label}
</BreadcrumbsItemLink>
</BreadcrumbsItem>
Expand Down