Skip to content

fix: DC-5439 Update kbd for docsearch - #7135

Merged
carlagn merged 2 commits into
mainfrom
fix/DC-5439-cropped-icons
Sep 17, 2025
Merged

fix: DC-5439 Update kbd for docsearch#7135
carlagn merged 2 commits into
mainfrom
fix/DC-5439-cropped-icons

Conversation

@carlagn

@carlagn carlagn commented Sep 17, 2025

Copy link
Copy Markdown
Contributor

Fixes #DC-5439

Summary by CodeRabbit

  • Bug Fixes

    • Fixed an unclosed CSS rule that affected code blocks inside modals, resolving layout glitches and ensuring consistent rendering, spacing, and alignment in modal content.
  • Style

    • Reduced padding to zero for keyboard-key indicators in DocSearch command hints, tightening spacing and improving visual alignment for a cleaner, more compact display.

@coderabbitai

coderabbitai Bot commented Sep 17, 2025

Copy link
Copy Markdown
Contributor

Walkthrough

Closed an unclosed CSS block for .mantine-Modal-body code and added a new rule to remove padding on .DocSearch-Commands-Key kbd in src/css/custom.css.

Changes

Cohort / File(s) Summary of Changes
Modal & DocSearch CSS fixes
src/css/custom.css
Added missing closing brace for .mantine-Modal-body code and added rule kbd.DocSearch-Commands-Key { padding: 0; }.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Possibly related PRs

Suggested reviewers

  • nikolasburk
  • nurul3101
  • Techboidesign
  • ankur-arch
  • aidankmcalister
  • mhessdev

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title Check ✅ Passed The title "fix: DC-5439 Update kbd for docsearch" is concise and directly reflects the primary change in the diff (updating kbd styling for DocSearch), includes the issue ID and a conventional "fix" prefix, and is clear enough for a teammate scanning history.
Docstring Coverage ✅ Passed No functions found in the changes. Docstring coverage check skipped.
✨ Finishing touches
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch fix/DC-5439-cropped-icons

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 2cf3afc and 844c568.

📒 Files selected for processing (1)
  • src/css/custom.css (1 hunks)
🚧 Files skipped from review as they are similar to previous changes (1)
  • src/css/custom.css
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (3)
  • GitHub Check: runner / linkspector
  • GitHub Check: Check internal links
  • GitHub Check: Lost Pixel

Comment @coderabbitai help to get the list of available commands and usage tips.

@github-actions

Copy link
Copy Markdown
Contributor

Dangerous URL check

No absolute URLs to prisma.io/docs found.
No local URLs found.

@github-actions

Copy link
Copy Markdown
Contributor

Redirect check

This PR probably requires the following redirects to be added to static/_redirects:

  • This PR does not change any pages in a way that would require a redirect.

@cloudflare-workers-and-pages

cloudflare-workers-and-pages Bot commented Sep 17, 2025

Copy link
Copy Markdown

Deploying docs with  Cloudflare Pages  Cloudflare Pages

Latest commit: 844c568
Status: ✅  Deploy successful!
Preview URL: https://625c0f3c.docs-51g.pages.dev
Branch Preview URL: https://fix-dc-5439-cropped-icons.docs-51g.pages.dev

View logs

coderabbitai[bot]
coderabbitai Bot previously approved these changes Sep 17, 2025
@carlagn
carlagn merged commit b57f1ae into main Sep 17, 2025
9 checks passed
@carlagn
carlagn deleted the fix/DC-5439-cropped-icons branch September 17, 2025 15:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants