site: restore the real pricing figures behind the spec table's TBCs - #8178
Merged
Conversation
The "Compare plans" table on /pricing shipped four rows of dashed "TBC" badges: cache tag invalidations, cache purge requests, Free-plan backups, and the support tiers. Those figures were never actually missing — they were carried by the pre-rebrand pricing table and lost in the rebrand merge (#8142), so the placeholders were shipping to users for values we already had. Restore them from apps/site/src/app/pricing/pricing-data.ts at 528ab05^, the same live table the current spec table was modelled on: - Cache tag invalidations: em dash on Free and Starter (the old table had a literal "-" there — not included), $0.002 per 1,000 max 10,000 per day on Pro, $0.001 per 1,000 max 100,000 per day on Business. - Cache purge requests: 5 / 5 / 10 / 20 per hour. - Support: Community / Community / Standard / Premium. - Backups on Free: em dash. Not in the old table at all, and /postgres/database/backups states snapshots are a Starter, Pro, and Business feature, so "not included" is the accurate cell rather than an unknown. With no placeholders left, the PENDING const and the dashed-badge branch in Cell are dead, so both come out along with three comments that still described the TBC-vs-em-dash convention (spec table header, cost bar, brand kit). The page has no reader-facing legend explaining a placeholder anymore — that note was pulled on 2026-07-30 — so the header comment now says to edit a figure rather than reintroduce one. Still open, and unchanged by this: Gregory said Accelerate is being deprecated, so whether the Global cache group belongs on the page at all is a separate call.
Contributor
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (3)
Included review availability: Your plan provides up to 4 included reviews per hour; 3 remain after this review. WalkthroughThe pricing table replaces four groups of TBC placeholders with restored values. The pending-value renderer and related placeholder guidance are removed. Comments now describe the remaining pricing question and future null-value support. ChangesPricing content updates
Estimated code review effort: 2 (Simple) | ~10 minutes Merge Risk: ⚪ Minimal · up to This PR restores missing pricing figures and removes obsolete placeholder rendering from the pricing page; no actionable merge-blocking risk remains beyond normal checks and review. Suggested reviewers: 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches 💡 1📝 Generate docstrings 💡
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The "Compare plans" table on
/pricingwas shipping four rows of dashed TBC badges to users. Those figures were never actually missing — they were carried by the pre-rebrand pricing table and lost in the rebrand merge (#8142).This restores them from
apps/site/src/app/pricing/pricing-data.tsat528ab05fc^, the same live table the current spec table was modelled on.What changed
Two of these are em dashes rather than restored numbers, deliberately:
-in the old data — not included, not unknown./postgres/database/backupsstates snapshots are a Starter, Pro, and Business feature. "Not included" is the accurate cell, not a guess.Cleanup
With no placeholders left, the
PENDINGconst and the dashed-badge branch inCellare dead code, so both come out — along with three comments that still described the TBC-vs-em-dash convention (spec table header,pricing-cost-bar.tsx,brand-kit/content.ts).The page has had no reader-facing legend explaining a placeholder since it was pulled on 2026-07-30, so the header comment now says to edit a figure rather than reintroduce one.
Two things worth a reviewer's call
pricing-comparison.tsxstill has TBC machinery (const PENDING = "TBC"+PendingBadge), but both comparison columns arepending: false, so nothing renders. Left in place as scaffolding for a future column — happy to strip it if you'd rather it went.Testing
oxlintclean on the changed files.types:checkreports only pre-existing "cannot find module" errors across the whole app (missing deps); nothing from these files.TBCremains anywhere on the pricing page.Summary by CodeRabbit