Skip to content

Themes - #4

Closed
marksteve wants to merge 10 commits into
progrium:masterfrom
marksteve:themes
Closed

marksteve wants to merge 10 commits into
progrium:masterfrom
marksteve:themes

Conversation

@marksteve

Copy link
Copy Markdown
Contributor

Added theme support. I had reservations about doing this since it makes things a little more complicated with the introduction of a config file (docs/.viewdocs [or maybe it should be at root so we could add another config like docsPath: documentation/]). But I was thinking about the non-creative guys that find it hard to design their own templates but want something different looking.

Some notes:

@progrium

Copy link
Copy Markdown
Owner

I appreciate that you found the project exciting enough to hack on, but I was wondering ... couldn't one just find a template.html file they like and use that? What can you do with this that you can't do like that?

There was a similar near PR that wanted to introduce configuration (#1), but we concluded it wasn't necessary.

@marksteve

Copy link
Copy Markdown
Contributor Author

Yep that's what I thought too hence the reservations. I just wanted template choices from viewdocs itself. How about a viewdocs-templates repo where people can copy and paste template.html files?

Btw, I like how you response so darn fast :))

@progrium

Copy link
Copy Markdown
Owner

That sounds like a good direction to go. Then, if we added a mechanism to
override the default template path via query parameter, then the docs for
viewdocs-templates could be an example page that links to itself using all
the different templates.

On Tue, Nov 12, 2013 at 7:47 PM, Mark Steve Samson <notifications@github.com

wrote:

Yep that's what I thought too hence the reservations. I just wanted
template choices from viewdocs itself. How about a viewdocs-templates repo
where people can copy and paste template.html files?

Btw, I like how you response so darn fast :))

—
Reply to this email directly or view it on GitHubhttps://github.com//pull/4#issuecomment-28361408
.

Jeff Lindsay
http://progrium.com

@marksteve

Copy link
Copy Markdown
Contributor Author

http://marksteve.viewdocs.io/viewdocs-templates

Can't figure out how to do previews easily :P Best I could think of is a viewdocs organization with a repo per template so it can be rendered with viewdocs itself. But viewdocs.viewdocs.io/yue-template is ugly haha.

Well I'll try to gather and create viewdocs templates for the meantime. No point in building the gallery if there's nothing to display yet. 😄

@marksteve marksteve closed this Nov 13, 2013
@progrium

Copy link
Copy Markdown
Owner

Let me know when there's a few and I'll take care of the preview bit.

On Tue, Nov 12, 2013 at 8:29 PM, Mark Steve Samson <notifications@github.com

wrote:

Closed #4 #4.

—
Reply to this email directly or view it on GitHubhttps://github.com//pull/4
.

Jeff Lindsay
http://progrium.com

@marksteve
marksteve deleted the themes branch November 13, 2013 05:09
@fgrehm

fgrehm commented Nov 13, 2013

Copy link
Copy Markdown
Contributor

I like the idea of having a gallery around, maybe we could also have a page with a list of projects using viewdocs so that people can look around for inspiration.
I'm planning to tweak one of the available templates for the github automatic page generator to use one of my projects. I'll send back a PR with a new page having a link link to it once I'm done :)

@fgrehm

fgrehm commented Nov 13, 2013

Copy link
Copy Markdown
Contributor

Oh, and regarding the idea of having a config file around, should we keep track of ideas that already came up on a list on a wiki page or placeholder issue that we can easily identify what we would get in case we end up adding support for that?

@progrium

Copy link
Copy Markdown
Owner

Wiki might be a good idea

On Wed, Nov 13, 2013 at 6:18 AM, Fabio Rehm notifications@github.laiyagushi.comwrote:

Oh, and regarding the idea of having a config file around, should we keep
track of ideas that already came up on a list on a wiki page or placeholder
issue that we can easily identify what we would get in case we end up
adding support for that?

—
Reply to this email directly or view it on GitHubhttps://github.com//pull/4#issuecomment-28397330
.

Jeff Lindsay
http://progrium.com

@marksteve

Copy link
Copy Markdown
Contributor Author

👍 Wiki

@fgrehm

fgrehm commented Nov 13, 2013

Copy link
Copy Markdown
Contributor

Awesome!
@progrium would u mind enabling the Wiki on the repo? :)

@progrium

Copy link
Copy Markdown
Owner

https://github.com/progrium/viewdocs/wiki

On Wed, Nov 13, 2013 at 6:47 AM, Fabio Rehm notifications@github.laiyagushi.comwrote:

Awesome!
@progrium https://github.com/progrium would u mind enabling the Wiki on
the repo? :)

—
Reply to this email directly or view it on GitHubhttps://github.com//pull/4#issuecomment-28399847
.

Jeff Lindsay
http://progrium.com

@fgrehm

fgrehm commented Nov 14, 2013

Copy link
Copy Markdown
Contributor

Just added the 2 that I could spot after a quick look at this issue and GH-1, feel free to move that out to a separate page and / or add more stuff :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants