ci: Update android-actions/setup-android to v4 - #59
Conversation
Upgrade setup-android action from v3 to v4 to resolve Node.js 20 deprecation warnings. Co-authored-by: Sisyphus <clio-agent@sisyphuslabs.ai>
📝 WalkthroughWalkthroughThe Android CI workflow's ChangesAndroid CI Workflow Update
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~2 minutes Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
이번 PR 본문은 @sisyphus-dev-ai 의 영혼을 담은 Kimi K2.6이 써줬어요 |
There was a problem hiding this comment.
🧹 Nitpick comments (1)
.github/workflows/android-ci.yml (1)
74-74: ⚡ Quick winConsider pinning GitHub Actions to commit hashes for supply-chain security.
While this is a pre-existing pattern in the workflow (all actions use tags, not commit hashes), GitHub security best practice recommends pinning actions to full commit SHA hashes instead of version tags. The v4 release incremented the major version to safeguard against potential breaks from the Node.js upgrade, which is a sound design, but using a commit hash (rather than a mutable tag like
v4) would prevent accidental or malicious updates to the tag after merge.This is not a blocker for this PR, but worth addressing across the workflow holistically.
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In @.github/workflows/android-ci.yml at line 74, The workflow uses the mutable tag "android-actions/setup-android@v4" which should be pinned to a full commit SHA for supply-chain security; update the uses entry for android-actions/setup-android to reference the action's immutable commit SHA (e.g., android-actions/setup-android@<full-commit-sha>) by looking up the action repository's latest v4 commit and replacing the tag with that SHA so the workflow pulls an exact revision.Source: Linters/SAST tools
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Nitpick comments:
In @.github/workflows/android-ci.yml:
- Line 74: The workflow uses the mutable tag "android-actions/setup-android@v4"
which should be pinned to a full commit SHA for supply-chain security; update
the uses entry for android-actions/setup-android to reference the action's
immutable commit SHA (e.g., android-actions/setup-android@<full-commit-sha>) by
looking up the action repository's latest v4 commit and replacing the tag with
that SHA so the workflow pulls an exact revision.
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro Plus
Run ID: 230ba92a-0a29-4320-9914-adf6f4fb299f
📒 Files selected for processing (1)
.github/workflows/android-ci.yml
|
Build check CI도 통과했으므로 병합하겠습니다. Coderabbit nitpick에서 나온 공급망 공격은 CI에서 Dev, QA 키만 사용해서 일단은 따로 관리하지는 않을게요. |
Please check if the PR fulfills these requirements
What kind of change does this PR introduce?
What is the current behavior?
.github/workflows/android-ci.ymlusesandroid-actions/setup-android@v3, which triggers the following Node.js 20 deprecation warning in GitHub Actions:See: https://github.blog/changelog/2025-09-19/deprecation-of-node-20-on-github-actions-runners/
What is the new behavior (if this is a feature change)?
Bumps
android-actions/setup-androidfromv3tov4.v4is the latest release of the action and runs on Node.js 24, removing the deprecation warning and keeping the workflow aligned with GitHub's runner roadmap.Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)
No. The action input interface is unchanged between v3 and v4, so no workflow or application changes are required.
ScreenShots (If needed)
Not applicable — CI workflow change only.
Other information:
ci/update-android-actions-v4was chosen because this change has no associated Jira ticket and only touches CI configuration. Theci/prefix follows the common convention for workflow/infrastructure-only changes, and the descriptive suffix indicates the exact dependency being updated.Summary by CodeRabbit