Deduplicate code across functions that populate small state event views#53
Merged
kevinaboos merged 1 commit intoFeb 26, 2024
Merged
Conversation
Fixes project-robius#48. This makes code simpler in the timeline drawing logic functions: * `fn populate_redacted_message_view()` * `fn populate_membership_change_view()` * `fn populate_profile_change_view()` * `fn populate_other_state_view()`
tyreseluo
pushed a commit
to tyreseluo/robrix
that referenced
this pull request
Apr 11, 2026
- Replace self.redraw(cx) with redraw_timeline_list() that only redraws the timeline PortalList, skipping input bar and typing notice - Skip redraw entirely when streaming messages are not visible in viewport - Apply same optimization to streaming timeout handler Closes project-robius#53
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #48.
This makes code simpler in the timeline drawing logic functions:
fn populate_redacted_message_view()fn populate_membership_change_view()fn populate_profile_change_view()fn populate_other_state_view()