Remove old unused IMG_LOADING resource#57
Merged
Conversation
tyreseluo
pushed a commit
to tyreseluo/robrix
that referenced
this pull request
Apr 11, 2026
Track the opening gesture (digit_id + capture_time) when showing a context menu, and consume the corresponding FingerUp event instead of treating it as a "click outside" dismissal. Fixes project-robius#57
tyreseluo
pushed a commit
to tyreseluo/robrix
that referenced
this pull request
Apr 11, 2026
The actual root cause of the trackpad press dismissal was FingerScroll(0,0): macOS generates a zero-scroll event on two-finger press, which the menu's unconditional `Hit::FingerScroll(_) => true` treated as a close trigger. - Only close on FingerScroll when scroll delta is non-zero - Restore capture_time field in ContextMenuOpenGesture for precise gesture matching (digit_id + capture_time from Makepad capture chain) Fixes project-robius#57
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.