Fix link preview image fit; decouple image viewer from room media cache#974
Merged
kevinaboos merged 2 commits intoJul 22, 2026
Merged
Conversation
kevinaboos
commented
Jul 22, 2026
Member
- The ImageViewer now directly handles fetching the full-size image instead of trying to route it through the room screen. So we basically rely on the matrix SDK's cache instead of our own.
- Make a bit more effort to obtain a full-size image (esp for link previews) if the thumbnail isn't available on the homeserver.
- Make sure link preview images are centered and fit within the image box
* The ImageViewer now directly handles fetching the full-size image instead of trying to route it through the room screen. So we basically rely on the matrix SDK's cache instead of our own. * Make a bit more effort to obtain a full-size image (esp for link previews) if the thumbnail isn't available on the homeserver. * Make sure link preview images are centered and fit within the image box
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.