paginate users - #2076
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #2076 +/- ##
=======================================
Coverage 91.58% 91.58%
=======================================
Files 159 159
Lines 7378 7378
=======================================
Hits 6757 6757
Misses 621 621 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
elsaperelli
left a comment
There was a problem hiding this comment.
It's looking good! I just noticed some minor formatting errors with the product table.
| @@ -46,6 +46,7 @@ export default class extends Controller { | |||
| }); | |||
| } | |||
|
|
|||
| // TODO: Remove when finished | |||
There was a problem hiding this comment.
Assuming these just need to be removed before merging?
| this.$(this.element).DataTable(options); | ||
|
|
||
| this.handleShown = this.handleShown.bind(this); | ||
| document.addEventListener("shown.bs.tab", this.handleShown); |
There was a problem hiding this comment.
Codex helped me identify this, but it looks like only handling the bootstrap tab is causing some formatting issues for the product tabs that use jQuery UI.
|
|
||
| this._boundBeforeStreamRender = this.onBeforeStreamRender.bind(this); | ||
| document.addEventListener( | ||
| "turbo:before-stream-render", | ||
| this._boundBeforeStreamRender, | ||
| ); |
There was a problem hiding this comment.
I think this code that was removed here should be included in the new datatable_controller in some capacity...don't have time today to finish investigating this, but wanted to put this up to see what you think!
Pull requests into Cypress require the following. Submitter and reviewer should ✅ when done. For items that are not-applicable, note it's not-applicable ("N/A") and ✅.
Submitter:
Reviewer 1:
Name:
Reviewer 2:
Name: