Please add "Suspended" as a node_zfs_zpool_state

[Hooloovoo]

Hello,

It is great that the node_exporter collects node_zfs_zpool_state. It currently has:
unavail
degraded
faulted
offline
online
removed

node_exporter/collector/zfs_linux.go

Line 45 in 68a6c78

var zfsPoolStatesName = []string{"online", "degraded", "faulted", "offline", "removed", "unavail"}

I had a pool that was in the "SUSPENDED" state:
$ zpool status
pool: [pool name]
state: SUSPENDED
status: One or more devices are faulted in response to IO failures.
action: Make sure the affected devices are connected, then run 'zpool clear'.
see: http://zfsonlinux.org/msg/ZFS-8000-HC

and so none of the above statuses were triggered (thankfully I also monitor for online != 1). Could you please add this status as well?

Host operating system: output of uname -a

Linux mythbuntu-server 5.4.0-121-generic #137-Ubuntu SMP Wed Jun 15 13:33:07 UTC 2022 x86_64 x86_64 x86_64 GNU/Linux

node_exporter version: output of node_exporter --version

n/a -- I am using Grafana agent, but they say:
grafana-cold-storage/agent#1854
that they are importing you directly as an upstream.

Are you running node_exporter in Docker?

No.

[conallob]

I would like to work on this, unless there is already someone actively working on it

[SuperQ]

@conallob Looks like there's already an open PR for this.