Skip to content

Revert "Add ZFS freebsd per dataset stats (#2753)" - #2925

Merged
SuperQ merged 1 commit into
prometheus:masterfrom
seeplusplus:revert_2753
Feb 14, 2024
Merged

SuperQ merged 1 commit into
prometheus:masterfrom
seeplusplus:revert_2753

Conversation

@seeplusplus

Copy link
Copy Markdown
Contributor

This reverts commit f34aaa6.

Resolves #2874 and #2896.
Caused by #2753.

This reverts commit f34aaa6.

Signed-off-by: Caleb Webber <caleb@codingthemsoftly.com>
@seeplusplus
seeplusplus force-pushed the revert_2753 branch 2 times, most recently from 28e2a4f to 5d25383 Compare February 14, 2024 01:15

ghost left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sad that we need to revert, but I agree, we should not block building.

@SuperQ
SuperQ merged commit 6d18ce7 into prometheus:master Feb 14, 2024
@seeplusplus

ghost commented Feb 14, 2024

Copy link
Copy Markdown
Contributor Author

@SuperQ I agree, it's not ideal. I'm going to post in #2693 (the original feature request) with, what I think are, next steps.

@SuperQ

ghost commented Feb 14, 2024

Copy link
Copy Markdown
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

FreeBSD13/FreeBSD14 sysctl get zfs zroot read and write info, parseFreeBSDPoolObjsetStats function

2 participants