Conversation
rtreffer
force-pushed
the
e2e-darwin-disk0
branch
from
September 21, 2026 14:57
b902d10 to
8ffbc6e
Compare
The Darwin end-to-end test scrapes the real macos-latest runner and diffs
the result against collector/fixtures/e2e-output-darwin.txt. We no longer
see disk4 on the nodes and that breaks the e2e tests.
This PR removes the usage of disk4 and the related fixtures:
-node_disk_read_errors_total{device="disk4"} 0
-node_disk_read_retries_total{device="disk4"} 0
-node_disk_write_errors_total{device="disk4"} 0
-node_disk_write_retries_total{device="disk4"} 0
This PR also adds a dump of the attached interfaces and disks
so we can more easily discover issues in the future.
Signed-off-by: René Treffer <treffer@measite.de>
rtreffer
force-pushed
the
e2e-darwin-disk0
branch
from
September 21, 2026 15:34
8ffbc6e to
6cd46b2
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Darwin end-to-end test scrapes the real macos-latest runner and diffs the result against collector/fixtures/e2e-output-darwin.txt. We no longer see disk4 on the nodes and that breaks the e2e tests.
This PR removes the usage of disk4 and the related fixtures:
-node_disk_read_errors_total{device="disk4"} 0
-node_disk_read_retries_total{device="disk4"} 0
-node_disk_write_errors_total{device="disk4"} 0
-node_disk_write_retries_total{device="disk4"} 0
This PR also adds a dump of the attached interfaces and disks so we can more easily discover issues in the future.