Skip to content

Add OpenBSD CPU collector - #805

Merged
SuperQ merged 1 commit into
prometheus:masterfrom
ra1fh:openbsd-cpu-collector
Feb 1, 2018
Merged

SuperQ merged 1 commit into
prometheus:masterfrom
ra1fh:openbsd-cpu-collector

Conversation

@ra1fh

@ra1fh ra1fh commented Jan 31, 2018

Copy link
Copy Markdown
Contributor
  • Tested on OpenBSD 6.2 and OpenBSD-current, single and multi CPU, i386 and amd64
  • Metric follows guidelines

@SuperQ SuperQ left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@SuperQ

SuperQ commented Jan 31, 2018

Copy link
Copy Markdown
Member

@discordianfish How do you think this compares to #727?

@discordianfish

Copy link
Copy Markdown
Member

Yes, this looks slightly better - though it still think we could avoid some duplication. But I think that's good for now. LGTM!

@SuperQ
SuperQ merged commit e3c76b1 into prometheus:master Feb 1, 2018
@SuperQ SuperQ mentioned this pull request Feb 1, 2018
@ra1fh
ra1fh deleted the openbsd-cpu-collector branch February 1, 2018 21:07
oblitorum pushed a commit to shatteredsilicon/node_exporter that referenced this pull request Apr 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants