Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions ci/spotbugs/exclude.xml
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,10 @@

<!-- pattern sort by alpha -->

<Match>
<Bug pattern="EI_EXPOSE_REP"/>
</Match>

<Match>
<Bug pattern="EI_EXPOSE_REP2"/>
</Match>
Expand Down
12 changes: 12 additions & 0 deletions src/main/java/io/github/protocol/bookkeeper/Configs.java
Original file line number Diff line number Diff line change
@@ -0,0 +1,12 @@
package io.github.protocol.bookkeeper;


import java.util.Map;

public interface Configs {

void putConfig(Map<String, String> config) throws Exception;

Map<String, String> getConfig() throws Exception;

Comment thread
Lico-Tom marked this conversation as resolved.
}
24 changes: 24 additions & 0 deletions src/main/java/io/github/protocol/bookkeeper/ConfigsImpl.java
Original file line number Diff line number Diff line change
@@ -0,0 +1,24 @@
package io.github.protocol.bookkeeper;


import java.net.http.HttpResponse;
import java.util.Map;

public class ConfigsImpl implements Configs {

private final InnerHttpClient innerHttpClient;

public ConfigsImpl(InnerHttpClient innerHttpClient) {
this.innerHttpClient = innerHttpClient;
}
@Override
public void putConfig(Map<String, String> config) throws Exception {
innerHttpClient.put(UrlConst.CONFIG_SERVER_CONFIG, JacksonService.toJson(config));
}

@Override
public Map<String, String> getConfig() throws Exception {
HttpResponse<String> resp = innerHttpClient.get(UrlConst.CONFIG_SERVER_CONFIG);
return JacksonService.toObject(resp.body(), Map.class);
}
}
48 changes: 48 additions & 0 deletions src/test/java/io/github/protocol/bookkeeper/ConfigsImplTest.java
Original file line number Diff line number Diff line change
@@ -0,0 +1,48 @@
package io.github.protocol.bookkeeper;

import io.github.embedded.bookkeeper.core.EmbeddedBookkeeperServer;
import org.junit.jupiter.api.AfterAll;
import org.junit.jupiter.api.Assertions;
import org.junit.jupiter.api.BeforeAll;
import org.junit.jupiter.api.Test;

import java.util.HashMap;
import java.util.Map;

public class ConfigsImplTest {


private static final EmbeddedBookkeeperServer SERVER = new EmbeddedBookkeeperServer();

private static ConfigsImpl configsImpl = null;

@BeforeAll
public static void setup() throws Exception {
SERVER.start();
Configuration conf = new Configuration();
conf.setHost("localhost");
conf.setPort(SERVER.getBkWebPort());
configsImpl = new ConfigsImpl(new InnerHttpClient(conf));
}

@Test
public void testPutConfig() throws Exception {
HashMap<String, String> config = new HashMap<>();
config.put("allowEphemeralPorts", "false");
configsImpl.putConfig(config);
Map<String, String> resp = configsImpl.getConfig();
Assertions.assertEquals("false", resp.get("allowEphemeralPorts"));

}

@Test
public void testGetConfig() throws Exception {
Map<String, String> config = configsImpl.getConfig();
Assertions.assertTrue(config.size() != 0);
}

@AfterAll
public static void teardown() throws Exception {
SERVER.close();
}
}