Destroy expired environments

[leightjohnson93]

The scheduled job doesn't seem to actually be cleaning up the expired environments instances. It just logs a message.

#83

[crohr]

@leightjohnson93 this is because the GitHub Token cannot perform the environment deletion. It can only delete deployments. There is a comment in the code about that:

# This requires repository permission, which the GitHub Action token cannot get, so cannot delete the environment unfortunately

[leightjohnson93]

@crohr So I don't understand, what's the point of having ttl if it doesn't work? I really just want to delete the instance so we aren't wasting money.

I think I meant to say instances and deployments instead.

Could we just like, remove the label after ttl?

[leightjohnson93]

@leightjohnson93 this is because the GitHub Token cannot perform the environment deletion. It can only delete deployments. There is a comment in the code about that:

# This requires repository permission, which the GitHub Action token cannot get, so cannot delete the environment unfortunately

What about the option to pass in our own github token with administrator permissions?

[Alanoll]

Could we add a new YAML option to attempt the deletion of the environment because we provided our own Github Token?

So:

• Merge these changes
• Additional change to signify "yes, we do have a token with permission"
• Uncomment the commented line so environments are deleted

There's already a YAML parameter github_token to provide a custom token.

This actions has steps to get a suitable token:
https://github.com/marketplace/actions/delete-deployment-environment

[crohr]

this will already be called when setting the GitHub status to destroyed -

action/lib/pull_preview/github_sync.rb

Line 271 in bcdf816

self.class.destroy_environment(repo, instance_name)

[crohr]

@crohr So I don't understand, what's the point of having ttl if it doesn't work? I really just want to delete the instance so we aren't wasting money.

I think I meant to say instances and deployments instead.

Could we just like, remove the label after ttl?

Instances are destroyed with the TTL, but the GitHub environment object is not, since it requires permissions the GitHub context cannot have.

Could we add a new YAML option to attempt the deletion of the environment because we provided our own Github Token?

Yes, I will open a separate PR for that