Fix some bugs that cause minor annoyances… - #22
Conversation
…during the build process. Claude ferreted these out; the precipitating annoyance was the fact that `yarn install` in the Pulsar repo often somehow forces me to re-run the download-`libiconv` step. Claude doesn't know why the existing version gets removed during that process, but says that `yarn build` doesn't catch the omission because the are-we-still-fresh metadata doesn't know to check for `libiconv.2.dylib`. Also, Claude spotted some bugs in the `fetch-libiconv-61.sh` script.
|
Since this PR was open, it became the testing ground for a bug I uncovered in While testing that bug, I also noticed that the Now that this is green, I'm gonna land it soon and then see if it fixes the Windows crashes (which, luckily, seem way more likely to happen in CI than in real life). |
…during the build process.
Claude ferreted these out; the precipitating annoyance was the fact that
yarn installin the Pulsar repo often somehow forces me to re-run the download-libiconvstep. Claude doesn't know why the existing version gets removed during that process, but says thatyarn builddoesn't catch the omission because the are-we-still-fresh metadata doesn't know to check forlibiconv.2.dylib. The fix is to move that file into the same directory assuperstring.node.Also, Claude spotted some bugs in the
fetch-libiconv-61.shscript.The proof here will be in the CI; if this works just as well in CI, then I'll consider it to be a lateral move at worst. These bugs would hardly ever surface during Pulsar builds because we're always starting from scratch, but fixing them may mean I have slightly fewer headaches.