Skip to content

Use qualified do notation where relevant - #88

Merged
nsaunders merged 3 commits into
purescript-hyper:masterfrom
JordanMartinez:updateDoNotation
Sep 7, 2019
Merged

Use qualified do notation where relevant#88
nsaunders merged 3 commits into
purescript-hyper:masterfrom
JordanMartinez:updateDoNotation

Conversation

@JordanMartinez

Copy link
Copy Markdown
Contributor

Builds off of #86 and uses new purescript-indexed-monad release, which includes a file for qualified do, to remove the writeStatus :*> closeHeaders style of code for normal do notation via qualified do notation.

@nsaunders

Copy link
Copy Markdown
Contributor

Thanks for the PR. FYI: Hyper.Middleware.QualifiedDo

@JordanMartinez

Copy link
Copy Markdown
Contributor Author

I'm aware of that file, but I thought it odd that such a file existed here rather than in the purescript-indexed-monads library, where it seemed more appropriate.

@JordanMartinez

Copy link
Copy Markdown
Contributor Author

With #86 closed, is this change desired if I rebased it?

@nsaunders

Copy link
Copy Markdown
Contributor

Indeed, I think it's a reasonable change. 👍

@JordanMartinez

Copy link
Copy Markdown
Contributor Author

Done.

@nsaunders
nsaunders merged commit 6eb9617 into purescript-hyper:master Sep 7, 2019
@nsaunders

Copy link
Copy Markdown
Contributor

Thanks @JordanMartinez !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants