Fix generator exhaustion in combine_by_coords#11265
Merged
headtr1ck merged 3 commits intoApr 2, 2026
Merged
Conversation
`combine_by_coords` accepts `Iterable[Dataset | DataArray]`. When a generator is passed, it is exhausted by the `DataTree` isinstance check before `objs_are_unnamed_dataarrays` is assigned, causing subsequent iterations to yield nothing and returning an empty Dataset. Fix by materializing `data_objects` into a list.
|
Thank you for opening this pull request! It may take us a few days to respond here, so thank you for being patient. |
headtr1ck
approved these changes
Mar 26, 2026
spencerkclark
pushed a commit
to spencerkclark/xarray
that referenced
this pull request
Apr 4, 2026
* Fix generator exhaustion in combine_by_coords `combine_by_coords` accepts `Iterable[Dataset | DataArray]`. When a generator is passed, it is exhausted by the `DataTree` isinstance check before `objs_are_unnamed_dataarrays` is assigned, causing subsequent iterations to yield nothing and returning an empty Dataset. Fix by materializing `data_objects` into a list. * Add entry in whats-new.rst
jsignell
pushed a commit
to jsignell/xarray
that referenced
this pull request
Apr 15, 2026
* Fix generator exhaustion in combine_by_coords `combine_by_coords` accepts `Iterable[Dataset | DataArray]`. When a generator is passed, it is exhausted by the `DataTree` isinstance check before `objs_are_unnamed_dataarrays` is assigned, causing subsequent iterations to yield nothing and returning an empty Dataset. Fix by materializing `data_objects` into a list. * Add entry in whats-new.rst
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request applies the suggested fix tracked in #10114 and fixes
combine_by_coordsreturning an empty Dataset when a generator is passed asdata_objects.whats-new.rst