[WAVE 1] Fix example content search paths - #1068
Conversation
1b3ac38 to
69400b0
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1068 +/- ##
==========================================
+ Coverage 77.26% 77.86% +0.60%
==========================================
Files 196 196
Lines 21506 21503 -3
==========================================
+ Hits 16616 16743 +127
+ Misses 4890 4760 -130
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Codex analysisCI follow-up after commit 66ad492:
The added content-search test calls filterByContent with an isolated example tree, so the changed search-path logic is now exercised without requiring a visible Qt window. |
pariterre
left a comment
There was a problem hiding this comment.
@pariterre reviewed 2 files and all commit messages, and made 1 comment.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on mickaelbegon).
Summary
bioptim/examplesinstead of the process working directoryRoot cause
Content search combined
os.getcwd()with only the top-level example category. Launchingpython -m bioptim.examplesoutside the examples directory therefore produced invalid paths, and nestedtoy_examples/...directories were discarded while flattening the tree.Validation
QT_QPA_PLATFORM=offscreen MPLCONFIGDIR=/private/tmp/bioptim-mpl-810 python -m pytest tests/shard1/test__run_examples.py::test_example_paths_are_preserved_when_flattening -q(1 passed)git diff --checkCloses #810
This change is