Repository navigation
Conversation
MbappeWU
marked this pull request as ready for review
October 5, 2026 21:39
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A resource registered with
Registry.with_resource("urn:foo#", resource)is stored underurn:foo.registry["urn:foo#"]finds it, butget_or_retrieve("urn:foo#")currently misses it and unnecessarily invokes retrieval.After the existing exact-key lookup, recognize a single empty-fragment alias when checking both known and crawlable resources. Exact constructor keys retain their priority. Unknown resources still pass the original URI to custom retrieval callbacks, and exception references remain unchanged. Nonempty fragments, including strings ending in another
#, and percent-escaped#stay distinct.Validation:
The local runtime/test results above were completed at
99ce258;29ebfa5changes only one changelog sentence, with all runtime and test bytes unchanged. The distributions were rebuilt at29ebfa5, passed strict Twine and archive checks, and passed the same public API helper from a new neutral Python 3.14 wheel installation.The first unmodified fork CI run did not pass: 28 jobs succeeded, 14 were cancelled because hosted runners were not acquired, macOS spelling rejected the changelog word
discoverable, and the dependent packaging job was skipped. The sentence now usesfound by crawling; the spelling check and word list remain unchanged. Local Enchant is unavailable, so local spelling is not counted as passing. The full original CI run at the corrected head now passes all 44 jobs. All 12 Python 3.13/3.14/3.14t/3.15 test jobs across Linux, macOS and Windows ran 511 tests successfully. The coverage job, style, typing, mypy, documentation builders including all three spelling jobs, native builds and final packaging also succeeded. The unchanged shallow-checkout packaging job produced version0.1.dev1+g29ebfa57b; the local full-history build produced0.37.1.dev251+g29ebfa57b. Both are validation snapshots. Tag-only publishing steps were skipped, and the temporarily enabled fork schedule was disabled after completion.Upstream Read the Docs and pre-commit checks pass. Upstream GitHub CI still requires maintainer approval; upstream review, merge and release remain pending.
AI assistance: OpenAI Codex prepared the implementation, regression tests and this description. Implementation and independent code/input reviews used gpt-5.6-luna sub-agents. No human review is claimed by those checks.