Why does validators.email include localhost in the domain whitelist?

[InnovativeInventor]

In a normal environment, localhost should not be a valid domain name. Why can't we just let the user configure the whitelist themselves?

Why should validators default to having localhost as a valid domain name?

[samuelchen]

some times may need localhost or even single word to be an available domain. e.g. use enter an local address . (mypc:8080, localhost:8080, 127.0.0.1:8080)
validators.domain('localhost') returns failure.

[InnovativeInventor]

@samuelchen : https://github.com/kvesteri/validators/blob/7fe92bd2ad1765d6e8e24d6aa6e6cad3434c9aa9/tests/test_url.py#L59-L60

Additionally, this should be made explicit -- localhost is not a valid domain. It never should be a valid domain, particularly in production when validating URLs.

The only mention of localhost in rfc 2606 is here: https://tools.ietf.org/html/rfc2606#section-2 where it specifies that *.localhost is a reserved domain for testing purposes. If somebody's use case requires a whitelist for domains that don't exist, then this should available as an option and not by default.

[samuelchen]

@InnovativeInventor thanks for response.
You are right at all. But your example is url, my scenaria is individual domain with port. So maybe I still need to write/find regular expression for it ...

[nandgator]

conflicts #185