[BUGFIX] Move *.dcm Files to data Subdirectory

[adam-grant-hendry]

vtk.vtkDICOMImageReader cannot parse non-dcm files in a folder. To fix this, place all *.dcm files in a separate data subfolder.

[MatthewFlamm]

First see comments in pyvista/pyvista#2460. Right now that PR isn't even downloading any data.

But I think you are right that the pyvista downloading functionality does not handle folders well currently. It only works well with a zip file. You may need to zip this data folder in a zip file.

IMO, it is easiest to test this whole thing out using https://docs.pyvista.org/extras/vtk_data.html

You can use your current PR branch to test locally. This means you don't need to have this PR merged to make sure it works right. Just make sure you clear your examples cache before testing.

[akaszynski]

You may need to zip this data folder in a zip file.

Fully agree. Most efficient to zip the files and certainly easier to download from pyvista.

[adam-grant-hendry]

@MatthewFlamm @akaszynski Thank you! Apologies, as this is my first PR. I also notice this PR is trying to add Data/FORGE.omf again. I'll fix this, zip my folder, and test locally.

[akaszynski]

I think you need to create a new branch from master:

git checkout master
git pull
git checkout -b feat/<name>

[adam-grant-hendry]

I think you need to create a new branch from master:

git checkout master
git pull
git checkout -b feat/<name>

When pulling from upstream (pyvista/vtk-data) into my local master, it kept saying I was already up to date when I still had Data/FORGE.omf in my local repo. So I couldn't push an update to my fork that would remove it. I was afraid that if I created a new branch and deleted the old one that this PR would get closed, which happened in #5 .

I decided instead to amend my local master (deleting the file), rebase bugfix/DICOM_Stack on top of it, and force push to my fork. I don't like force pushing (I know it's typically a big no-no). I couldn't get my fork in sync with pyvista/vtk-data, and the screw up was up on my end, so I felt this was the right move. No one else is using my fork, so there's no risk of me screwing up others' work.

[akaszynski]

Were you planning on zipping this or leaving as is?

[adam-grant-hendry]

Were you planning on zipping this or leaving as is?

I zipped it. It's in Data/DICOM_Stack/data.zip.

[adam-grant-hendry]

@pyvista/developers @akaszynski Would you please kindly review and let me know if this PR is okay?

[akaszynski]

LGTM, thanks!