This repository was archived by the owner on Jun 11, 2026. It is now read-only.
Fix clippy lints for Rust 1.96 - #116
Open
qdrant-cloud-bot wants to merge 1 commit into
Open
Conversation
Resolve clippy errors that break CI on newer toolchains: - use sort_by_key instead of sort_by with cmp - use Vec::pop_if instead of manual last()/pop() Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
CI is currently red (e.g. on #115) because newer clippy (1.96.0) introduced lints that, combined with
-D warnings, fail the build. These are unrelated to the dependabot bump but block all PRs.This PR fixes the lint errors in
src/lib.rs:unnecessary_sort_by: replacesort_by(|a, b| a.x.cmp(&b.x))withsort_by_key(|a| a.x)(2 occurrences)manual_pop_if: replace manuallast()+pop().unwrap()withVec::pop_ifTest plan
cargo clippy --all-targetspasses locally with no warningsMade with Cursor