This repository was archived by the owner on Jun 11, 2026. It is now read-only.
Drop memmap before file remaning or deletion - #67
Closed
IvanPleshkov wants to merge 1 commit into
Closed
Conversation
timvisee
reviewed
Jan 5, 2024
timvisee
left a comment
Member
There was a problem hiding this comment.
Nice! On Linux this is fine, but we didn't think about Windows here 😄
Member
|
Why is it better than proposal here #64 ? It looks like we still need to read from disk when segment is closed/renamed |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.