This repository was archived by the owner on Jun 11, 2026. It is now read-only.
Copy wal files using memcpy - #68
Merged
Merged
Conversation
timvisee
reviewed
Jan 10, 2024
IvanPleshkov
marked this pull request as draft
January 11, 2024 10:33
IvanPleshkov
marked this pull request as ready for review
January 16, 2024 10:37
timvisee
reviewed
Jan 16, 2024
timvisee
approved these changes
Jan 16, 2024
9 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix of qdrant/qdrant#2620 on WAL side.
Avoid copy file as
fs::copywhen mmap is locked by segment. Copying is implemented as new file creation andmemcpyover all data. More detailed description why we need such copy you can find here:#64