fix: handle negative imaginary parts in number_to_string - #616
Open
Sanjays2402 wants to merge 1 commit into
Open
fix: handle negative imaginary parts in number_to_string#616Sanjays2402 wants to merge 1 commit into
Sanjays2402 wants to merge 1 commit into
Conversation
number_to_string built the normalized complex string by unconditionally joining the real and imaginary parts with '+'. When the imaginary part is negative the rendered part already carries its own sign, producing a malformed literal such as '1.0+-1.0j', which complex() rejects with ValueError. Any comparison involving such a number crashed. The sign separator is now omitted when the rendered imaginary part is already negative. Regression cases added to the existing test_number_to_string_complex_digits parametrize list. Closes qlustered#551
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #551
number_to_stringjoined the rendered real and imaginary parts with a hardcoded+, so a negative imaginary part produced a malformed literal like1.0+-1.0j, whichcomplex()rejects —number_to_string(1-1j, significant_digits=1)raisedValueError, and so did any diff/hash comparison involving such a number. The separator is now omitted when the rendered imaginary part is already negative.Four cases added to the existing
test_number_to_string_complex_digitsparametrize list intests/test_helper.py; they fail onmasterand pass with the fix.This change was prepared with AI assistance; the regression test was run locally and fails without the fix.