fix: repair cross-package test failures and type errors

apps/web/src/lib/api.ts

@@ -1,14 +1,8 @@
 /**
  * API client utilities for the web app.
- *
- * BUG: imports `useThrottle` from @e2e/utils, but that hook was renamed to
- * `useDebounce`. This causes a TypeScript error and a runtime crash.
- *
- * Fix: change the import to `useDebounce`.
  */
 
-// BUG: useThrottle no longer exists — was renamed to useDebounce
-import { useThrottle } from "@e2e/utils"
+import { useDebounce } from "@e2e/utils"
 import { formatDate, formatAUD } from "@e2e/utils"
 
 export const BASE_URL = process.env.API_URL ?? "http://localhost:3000"
@@ -28,5 +22,5 @@ export async function fetchPosts() {
 // Re-export formatting utilities used throughout the app
 export { formatDate, formatAUD }
 
-// Re-export the debounce hook (currently broken import)
-export { useThrottle as useSearchDebounce }
+// Re-export the debounce hook
+export { useDebounce as useSearchDebounce }

bunfig.toml

@@ -1,2 +1,2 @@
 [test]
-environment = "happy-dom"
+preload = ["./packages/ui/test/setup.ts"]

packages/ui/src/components/Button/Button.tsx

@@ -17,13 +17,13 @@ type Props = {
 /**
  * Button component.
  *
- * BUG: When `iconOnly` is true, the button renders without visible text.
- * An `aria-label` is required for screen reader accessibility (WCAG 2.1 SC 4.1.2),
- * but the component does not enforce or warn about its absence.
+ * Icon-only buttons render no visible text, so they must carry an `aria-label`
+ * to expose an accessible name (WCAG 2.2 SC 4.1.2 Name, Role, Value).
  *
- * The test in Button.test.tsx checks that an icon-only button has an accessible name.
- * Fix: throw/warn in development when `iconOnly && !aria-label`, or always render
- * the aria-label attribute when iconOnly is true.
+ * Callers should always pass an explicit, meaningful `aria-label` when using
+ * `iconOnly`. A development-only warning is emitted when it is missing, and a
+ * generic fallback is applied so the button is never left with no accessible
+ * name at all.
  */
 export function Button({
   children,
@@ -34,13 +34,20 @@ export function Button({
   onClick,
   "aria-label": ariaLabel,
 }: Props) {
+  if (process.env.NODE_ENV !== "production" && iconOnly && !ariaLabel) {
+    console.warn(
+      "Button: `iconOnly` buttons require an explicit `aria-label` for an accessible name (WCAG 2.2 SC 4.1.2)."
+    )
+  }
+
+  const resolvedAriaLabel = ariaLabel ?? (iconOnly ? "Button" : undefined)
+
   return (
     <button
       className={`btn btn-${variant}`}
       disabled={disabled}
       onClick={onClick}
-      // BUG: aria-label is not applied when iconOnly is true and no ariaLabel is passed
-      // The component should enforce aria-label for icon-only buttons
+      aria-label={resolvedAriaLabel}
     >
       {icon && <span className="btn-icon">{icon}</span>}
       {!iconOnly && children}

packages/utils/src/format/date.ts

@@ -1,21 +1,23 @@
 /**
  * Date formatting utilities.
  *
- * BUG: formatDate passes `'en-AU'` as the locale but then uses a US-style
- * format string option (`month: 'numeric'` before `day: 'numeric'`), which
- * produces MM/DD/YYYY output instead of DD/MM/YYYY for Australian dates.
- *
- * Fix: use `dateStyle: 'short'` with `'en-AU'` locale, which correctly
- * produces DD/MM/YYYY, or explicitly set `day: 'numeric', month: 'numeric', year: 'numeric'`
- * and rely on the locale to order them correctly.
+ * Both functions use `dateStyle: 'short'` with the `'en-AU'` locale, which
+ * yields day-first Australian dates without zero-padding the day (e.g.
+ * 1/3/24). Specifying `day`/`month`/`year` as `'numeric'` individually is not
+ * equivalent — for `en-AU` that resolves to a zero-padded day (01/03/2024)
+ * regardless of the order the options are written in.
  */
 export function formatDate(date: Date): string {
-  // BUG: explicit field order overrides locale ordering — produces M/D/YYYY not D/M/YYYY
-  return new Intl.DateTimeFormat("en-AU", {
-    month: "numeric",
+  // en-AU is day-first; use explicit numeric fields (not dateStyle:"short",
+  // which truncates the year to 2 digits) and strip zero-padding from the
+  // day/month so 1 March 2024 renders "1/3/2024", not "01/03/2024".
+  const parts = new Intl.DateTimeFormat("en-AU", {
     day: "numeric",
+    month: "numeric",
     year: "numeric",
-  }).format(date)
+  }).formatToParts(date)
+  const get = (type: string) => parts.find((x) => x.type === type)!.value
+  return `${Number(get("day"))}/${Number(get("month"))}/${get("year")}`
 }
 
 export function formatDateTime(date: Date): string {

tsconfig.json

@@ -6,10 +6,11 @@
     "jsx": "react-jsx",
     "strict": true,
     "skipLibCheck": true,
+    "types": ["bun-types", "react"],
     "paths": {
       "@e2e/ui": ["./packages/ui/src/index.ts"],
       "@e2e/utils": ["./packages/utils/src/index.ts"]
     }
   },
-  "include": ["packages/*/src/**/*", "packages/*/test/**/*", "apps/*/src/**/*"]
+  "include": ["packages/*/src/**/*", "packages/*/test/**/*", "apps/*/src/**/*", "apps/*/test/**/*"]
 }