Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
bun test && tsc --noEmitnow passes: 13 tests pass, 0 fail, and tsc exits 0. No test files or dependencies were changed.useThrottle. It now importsuseDebounce, which is what@e2e/utilsexports.aria-label. The fallback now uses||instead of??, so an empty label also falls back. When no label is given it falls back to string children, then to "Button". A warning still prints in dev mode.setState.formatDatenow gives en-AUd/MM/yyyyoutput, for example1/03/2024.formatDateTimenow reusesformatDatefor its date part."types": ["bun-types"]so tsc can findbun:test.bun-typeswas already installed.environment = "happy-dom", so a plainbun testfailed withdocument is not defined. I replaced it with apreloadof the existingpackages/ui/test/setup.ts.Assumptions
formatDateTimeoutput changes (1/3/24becomes1/03/2024) even though no test covers it. I kept it so it matches the DD/MM/YYYY format the docs describe; it can be reverted if preferred.aria-label.