Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
bun test && tsc --noEmitnow passes from the root: 13 tests pass, 0 fail, and tsc reports no errors. No test files were modified and no dependencies were added.useThrottlewas renamed touseDebouncein@e2e/utils.api.tsnow imports the new name and still exports it asuseSearchDebounce.formatDatenow prints the day without a leading zero (1/03/2024) while keeping en-AU day-first order and a 4-digit year.aria-labelis now put on the<button>. Before, it was read from props and never used. Icon-only buttons with no label fall back to string children, then to"Button", and log a warning outside production.prev => ...).bunfig.tomlnow preloads the happy-dom registrator that was already there. The oldenvironment = "happy-dom"key does nothing in Bun, so the UI tests had no DOM.tsconfig.jsonnow includesbun-typessobun:testresolves.Assumptions / known compromises
aria-labeleven when none is passed. The generic"Button"fallback meets the test, but it gives screen reader users no useful name. The warning is there so developers add real labels.formatDateTimestill usesdateStyle: "short", so the two functions now print dates differently.